Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

slate-tools ships with Eslint 4 but references Eslint 5 definitions #800

Open
magnuspaaske opened this issue Oct 7, 2018 · 3 comments
Open

Comments

@magnuspaaske
Copy link

Slate depends on eslint@^4.12.0 but the eslint slate config references some settings that were only introduced in version 5 (prefer-object-spread) and version 5.3 (no-misleading-character-class and require-atomic-updates).

The best way to solve this would probably be to update the requirement to eslint@^5.3.0 for slate-tools

@t-kelly
Copy link
Contributor

t-kelly commented Oct 9, 2018

Good catch! Thanks @magnuspaaske.

@tanhengyeow
Copy link

Hi @t-kelly

I'm a new contributor for Shopify and would love to be assigned this issue 😄

@t-kelly
Copy link
Contributor

t-kelly commented Oct 12, 2018

@tanhengyeow thanks for volunteering. Open a PR and let's get this fixed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants