Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow export of REST Resource Types from the @shopify/shopify-api package #814

Open
5 tasks done
HadiMalikDev opened this issue Aug 8, 2024 · 1 comment
Open
5 tasks done

Comments

@HadiMalikDev
Copy link

HadiMalikDev commented Aug 8, 2024

Issue summary

Before opening this issue, I have:

  • Upgraded to the latest version of the @shopify packages
    • Affected @shopify/shopify-* package and version: v2024.07.16
    • Node version: 20.12.2
    • Operating system: Mac OS Sonoma
  • Set { logger: { level: LogSeverity.Debug } } in my configuration
  • Found a reliable way to reproduce the problem that indicates it's a problem with the package
  • Looked for similar issues in this repository
  • Checked that this isn't an issue with a Shopify API

After the @shopify/shopify-api package was removed as a direct dependency from the package, I can no longer import the types for the REST Resources, such as Product, Variant, and Order etc. More information can be found here

Expected behavior

I should be able to import the aforementioned types from the @shopify/shopify-api package the same way as I could, before the package was removed as direct dependency

Actual behavior

The types are no longer exported, as they could be when the @shopify/shopiyf-api package was a direct dependency

Steps to reproduce the problem

  1. Create a boilerplate remix app
  2. Try importing any type, such as Product using import type { Product } from "node_modules/@shopify/shopify-api/dist/ts/rest/admin/2024-04/product";

Debug logs

Not applicable

@lizkenyon
Copy link
Contributor

Thanks for creating this issue! The team will triage it, and look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants