Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Add a new utility for constructing the host URL for the app. #419

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Add a new utility for constructing the host URL for the app. #419

merged 4 commits into from
Jul 14, 2022

Commits on Jul 12, 2022

  1. Add a new utility for constructing the host URL for the app.

    @byrichardpowell
    byrichardpowell committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    f017e0a View commit details
    Browse the repository at this point in the history

  2. Add changes to changelog under unreleased

    @byrichardpowell
    byrichardpowell committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    acf25dc View commit details
    Browse the repository at this point in the history

  3. Add documentation

    @byrichardpowell
    byrichardpowell committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    467c386 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. PR Feedback 

    1. Correct typo
2. Change utility name "getHostAppUrl" to "getEmbeddedAppUrl", which is much nicer.
3. Add / to the host in our test.  This matches the format of the host that Shopify provides
4. Flesh out the docs a little more.
5. Use new URL, rather than url.parse. url.parse is deprecated.
    @byrichardpowell
    byrichardpowell committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    4cf0bef View commit details
    Browse the repository at this point in the history