Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

allow for non-json responses in the body #398

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

JaKXz
Copy link
Contributor

@JaKXz JaKXz commented May 31, 2022

Co-Authored-By: Paulo Margarido [email protected]

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change

- refactors HttpClient#doRequest method to pull out nested .then callback
- based on PR #1472

Co-Authored-By: Paulo Margarido <[email protected]>
@JaKXz JaKXz requested a review from a team as a code owner May 31, 2022 14:18
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@JaKXz JaKXz mentioned this pull request May 31, 2022
6 tasks
JaKXz and others added 2 commits May 31, 2022 16:30
@JaKXz JaKXz merged commit 7642465 into main Jun 1, 2022
@JaKXz JaKXz deleted the jakxz/fix/non-json-body-handling branch June 1, 2022 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants