This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Fix transient json parse error #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
| @@ -260,6 +260,8 @@ class HttpClient { | |||
| .catch((error) => { | |||
| if (error instanceof ShopifyErrors.ShopifyError) { | |||
| throw error; | |||
| } else if (typeof error === 'object' && error.name === 'FetchError' && error.type === 'invalid-json') { | |||
There was a problem hiding this comment.
I might extract this complicated if statement into a function
isRetriableError(error)
For all shopify requests we expect to receive json response. When non json response is received `HttpRequestError` was thrown instead of `HttpRetriableError`. See: #257
Extracted logic to separate function.
Prettier was added to the project so this code had to be adapted to the change. See: https://github.com/wszaranski/shopify-node-api/commit/420b799a64fed48be45eea465bf99984b94a3372
It is possible to get 200 response but with non json response. This should still be treated as error.
|
Hey @wszaranski thanks for the PR, but we've decided to go with the solution here in #398 because we wanted to refactor the #doRequest method anyway and we wanted a "simpler" fix. I'm going to close this for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all shopify requests we expect to receive json response. When non
json response is received
HttpRequestErrorwas thrown instead ofHttpRetriableError.FIXES #257
Type of change
Checklist