Web "React is not defined" Fix #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathan-ahn that's a fair change indeed. |
|
🎉 This PR is included in version 1.11.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Fix
We were running into a
"React is not defined"error using Skia on web for both Next.js and Storybook. This PR re-introduces the React import that previously existed before the new web reconciler in Canvas.tsx. One thing that I'm not sure about is if auto-format will remove this import. I don't have formatting working on my local repository, so I can't test. We don't want to accidentally regress when a developer formats this file.Test Plan
Patch allows for Skia rendering in both Next.js and Storybook. I can't verify full functionality since our web animations are broken in some newer version, but animation issues seem unrelated to this
"React is not defined"issue. We're at least able to render static screens with this patch.