[CheckableButton] Fix position of Checkbox #6913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
alex-page
reviewed
Aug 10, 2022
| margin-left: calc( | ||
| -1 * ((var(--p-space-2) + var(--p-space-025))) - var(--p-control-border-width) | ||
| ); // 1px accounts for border | ||
| -1 * (var(--p-space-2) + var(--p-space-025)) |
Member
There was a problem hiding this comment.
Oof. I wish this used a token.
Contributor
Author
There was a problem hiding this comment.
This would probably be a one off token
Member
There was a problem hiding this comment.
I don't mean we should add it now. This should be refactored in the future to not do this. Ship it, this alignment is important.
alex-page
approved these changes
Aug 10, 2022
dleroux
force-pushed
the
bulk-action-checkbox-shift
branch
2 times, most recently
from
24bb9ae to
c3e242c
Compare
dleroux
force-pushed
the
bulk-action-checkbox-shift
branch
from
c3e242c to
c3ccde6
Compare
Contributor
Author
|
My previous fixed caused an issue with ResourceItem. This will fix it. |
Merged
sam-b-rose
added a commit
that referenced
this pull request
Aug 12, 2022
* main: Fix casing of Active status icon and URL for the Figma icon library (#6942) Remove /examples from sitemap (#6935) Add missing icon Add missing icon Fix link to tokens api Move tokens API to match other api versions (#6891) Update contribution guidelines with ux review feedback (#6310) Fix link (#6930) feat(polaris-icons): Add fulfillment icons (FulfillmentFulfilledMajor, FulfillmentOnHoldMajor) (#6928) remove additional pixel from checkbox on checkable button (#6913) Add status code and content type header for og-image OG image api (#6858) Adding clarification for `About` native section (#6887) Replaced glob with globby (#6881) Version Packages (#6801) Fix @shopify/polaris link version Get the next @shopify/polaris version from the changset info (#6882) [polaris.shopify.com] Update space documentation visual example (#6885) Adds `About Polaris` page to polaris.shopify.com (#6857) removing slug from design-patterns.md (#6884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
WHAT is this pull request doing?
Removed the extra pixel when the checkbox is checked.
🎩 checklist
README.mdwith documentation changes