Replaced glob with globby #6881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
laurkim
reviewed
Aug 9, 2022
laurkim
approved these changes
Aug 9, 2022
sam-b-rose
requested changes
Aug 9, 2022
Member
sam-b-rose
left a comment
sam-b-rose
left a comment
There was a problem hiding this comment.
Really like this glob/**/*.swap 👍
Only suggestion would be to add globby to the individual project/package.json instead of the root. This may seem redundant, but it will help us with migration to pnpm and is more accurate given globby is used for the package's source and scripts rather than for the root monorepo's tasks and tooling
This was referenced Aug 9, 2022
Merged
sam-b-rose
added a commit
that referenced
this pull request
Aug 12, 2022
* main: Fix casing of Active status icon and URL for the Figma icon library (#6942) Remove /examples from sitemap (#6935) Add missing icon Add missing icon Fix link to tokens api Move tokens API to match other api versions (#6891) Update contribution guidelines with ux review feedback (#6310) Fix link (#6930) feat(polaris-icons): Add fulfillment icons (FulfillmentFulfilledMajor, FulfillmentOnHoldMajor) (#6928) remove additional pixel from checkbox on checkable button (#6913) Add status code and content type header for og-image OG image api (#6858) Adding clarification for `About` native section (#6887) Replaced glob with globby (#6881) Version Packages (#6801) Fix @shopify/polaris link version Get the next @shopify/polaris version from the changset info (#6882) [polaris.shopify.com] Update space documentation visual example (#6885) Adds `About Polaris` page to polaris.shopify.com (#6857) removing slug from design-patterns.md (#6884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v11.1.0so it supports commonjs and esm