[polaris.shopify.com] Fix React hooks warnings in examples #6756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
ghost
added
the
cla-needed
Contributor
Author
|
@alex-page I've signed CLA, I think we need to rerun workflow. I'll also update README files to have correct examples. |
ghost
removed
the
cla-needed
mrkldshv
force-pushed
the
bugfix/example-react-hooks-warnings
branch
from
c0bd384 to
483d287
Compare
alex-page
approved these changes
Jul 26, 2022
|
🎉 Thanks for your contribution to Polaris! |
Member
|
Thanks @mrkldshv for the contribution. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #6615
WHAT is this pull request doing?
Fixes usage of
useEffectanduseCallbackhooks in examples.Warnings were resolved by:
useMemouseEffectanduseCallbackdependency arrays