-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[polaris.shopify.com] Create typography-updates.md #6697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Beautiful! Quick thought: You, José, Erin and I (and others) should align on how to work with graphics:
Not a blocker for now, but something for us to discuss before we start shipping tons of assets. |
missed bottom border
|
Thanks @martenbjork that makes sense! I updated the images to:
For now I just made a new page for "Assets" with a subpage for "News" to house these images. https://www.figma.com/file/GV7HHVTBCEPDXnemkQ1rv3/Foundations-guidance?node-id=965%3A67328 We'll have to decide what we want the radius and border to be but I'm fine with removing them for now and adding it via CSS when that decision is made. Feels better for scaling and updating later. |
Aces! Thanks, Sara! 🙌 These graphics are beautiful BTW. |
|
@martenbjork does this require a changelog entry? I know this PR is also dependent on the addition of the new "News / Updates" section which I assume will be a separate PR but wasn't sure. |
|
Yeah, right now anything going into |
Adding a page to the style guide for the typography updates post. After chatting with @alex-page we are going to add a news/updates section for content like this to live.
Fixes https://github.com/orgs/Shopify/projects/2250/views/63