Skip to content

Conversation

@sarahill
Copy link
Contributor

@sarahill sarahill commented Jul 20, 2022

Adding a page to the style guide for the typography updates post. After chatting with @alex-page we are going to add a news/updates section for content like this to live.

Fixes https://github.com/orgs/Shopify/projects/2250/views/63

Screen Shot 2022-07-25 at 8 29 06 AM

Screen Shot 2022-07-25 at 8 29 17 AM

Screen Shot 2022-07-25 at 8 29 29 AM

@sarahill sarahill added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Jul 20, 2022
@sarahill sarahill marked this pull request as ready for review July 20, 2022 23:32
@sarahill sarahill requested a review from alex-page July 20, 2022 23:32
@sarahill sarahill self-assigned this Jul 20, 2022
sarahill and others added 4 commits July 21, 2022 08:05
@sarahill sarahill requested a review from martenbjork as a code owner July 21, 2022 22:15
@sarahill sarahill removed the 🤖Skip Changelog Causes CI to ignore changelog update check. label Jul 21, 2022
@martenbjork
Copy link
Contributor

Beautiful!

Quick thought: You, José, Erin and I (and others) should align on how to work with graphics:

  • We should probably have a Figma file where all the website assets live
  • We should export as much as possible as SVGs
  • We should let the website do the rounding of corners so that it stays consistent across all images. It also allows us to change this later or on different breakpoints.
  • We should let the website add borders to graphics (if we want that). That way, borders remain 1px, even when scaled down.

Not a blocker for now, but something for us to discuss before we start shipping tons of assets.

sarahill added 2 commits July 25, 2022 08:17
missed bottom border
@sarahill
Copy link
Contributor Author

Thanks @martenbjork that makes sense!

I updated the images to:

  • remove border radius
  • remove any borders
  • adjusted the aspect ratio

For now I just made a new page for "Assets" with a subpage for "News" to house these images. https://www.figma.com/file/GV7HHVTBCEPDXnemkQ1rv3/Foundations-guidance?node-id=965%3A67328

We'll have to decide what we want the radius and border to be but I'm fine with removing them for now and adding it via CSS when that decision is made. Feels better for scaling and updating later.

cc: @adrianefong @zecarlostorre @erncat

@martenbjork
Copy link
Contributor

I updated the images to:

Aces! Thanks, Sara! 🙌 These graphics are beautiful BTW.

@sarahill
Copy link
Contributor Author

@martenbjork does this require a changelog entry? I know this PR is also dependent on the addition of the new "News / Updates" section which I assume will be a separate PR but wasn't sure.

@martenbjork
Copy link
Contributor

martenbjork commented Jul 25, 2022

Yeah, right now anything going into main needs a changelog entry. I don't mind this being merged for now, and then we'll add the news functionality very soon in a separate PR.

@sarahill sarahill merged commit 8296f43 into main Jul 25, 2022
@sarahill sarahill deleted the polaris-type-updates-post branch July 25, 2022 20:36
This was referenced Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants