Skip to content

[polaris.shopify.com] Clean up example titles #6678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jul 22, 2022
Merged

[polaris.shopify.com] Clean up example titles #6678

merged 27 commits into from
Jul 22, 2022

Conversation

@alex-page
Copy link
Member

@alex-page alex-page commented Jul 20, 2022 •
edited
Loading

  • Removed component names from example titles as they are on the page title
  • Removed simple or basic from example titles
  • Updated README, content and examples dir
  • Fixed markdown issues when investigating migration
  • Tophatted all examples and logged issues in [polaris.shopify.com] Example audit #6706

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2022 •
edited
Loading

size-limit report 📦

Path Size
polaris-react-cjs 198.16 KB (0%)
polaris-react-esm 133.08 KB (0%)
polaris-react-esnext 188.22 KB (0%)
polaris-react-css 41.74 KB (0%)

alex-page added 20 commits July 20, 2022 07:28
@alex-page alex-page requested a review from martenbjork July 21, 2022 06:46
@alex-page alex-page marked this pull request as ready for review July 21, 2022 06:47
@alex-page alex-page mentioned this pull request Jul 21, 2022
Closed
27 tasks
@martenbjork martenbjork changed the title Clean up example titles [polaris.shopify.com] Clean up example titles Jul 21, 2022
martenbjork
martenbjork approved these changes Jul 21, 2022
View reviewed changes
martenbjork
martenbjork approved these changes Jul 21, 2022
View reviewed changes
polaris-react/src/components/VideoThumbnail/README.md
## Examples

### Basic video thumbnail
### Default
Copy link
Contributor

@martenbjork martenbjork Jul 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help a tired person out: Why do we not delete these readmes? Aren't they 1:1 with what's in the website directory? Is that part of your migration strategy?

Copy link
Member Author

@alex-page alex-page Jul 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this so I could make sure we didn't lose any content as it hadn't been migrated across in a long time. We definitely should delete them but first I need to make sure the content is not lost.

Copy link
Contributor

@martenbjork martenbjork Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha!

@alex-page alex-page merged commit 5179877 into main Jul 22, 2022
@alex-page alex-page deleted the clean-up-example-titles branch July 22, 2022 03:47
@github-actions github-actions bot mentioned this pull request Jul 22, 2022
Merged
@laurkim laurkim mentioned this pull request Jul 22, 2022
Merged
5 tasks
@github-actions github-actions bot mentioned this pull request Jul 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@martenbjork martenbjork martenbjork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex-page @martenbjork