[IndexTable] Fix bulk actions on small screens #6583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
chloerice
approved these changes
Jul 11, 2022
Member
chloerice
left a comment
chloerice
left a comment
There was a problem hiding this comment.
Tophatted on iPhone in Safari and Chrome and changes work great, thanks for jumping in to fix this @FCalabria!!
.changeset/nasty-pianos-shout.md
Outdated
| '@shopify/polaris': patch | ||
| --- | ||
|
|
||
| Fix bulk actions not visible on IndexTable on small screens |
Member
There was a problem hiding this comment.
Suggested change
| Fix bulk actions not visible on IndexTable on small screens | |
| Fixed `IndexTable` bulk action visibility on small screens |
Comment on lines
255
to
258
| const newSmallScreen = isSmallScreen(); | ||
| if (smallScreen !== newSmallScreen) { | ||
| setSmallScreen(newSmallScreen); | ||
| } |
Member
There was a problem hiding this comment.
I think we can remove the conditional here because states only get updated if the value passed to the setter method is not the same as the current value.
Suggested change
| const newSmallScreen = isSmallScreen(); | |
| if (smallScreen !== newSmallScreen) { | |
| setSmallScreen(newSmallScreen); | |
| } | |
| setSmallScreen(isSmallScreen()); |
Merged
5 tasks
AndrewMusgrave
added a commit
that referenced
this pull request
Oct 19, 2022
### WHY are these changes introduced? There was a [change](#6583) that updated how index table behaves on small screens. However, the variable setting small screen state is not correctly updated on resize causing the not to be incorrect when moving from large -> small or small -> large. ### WHAT is this pull request doing? Updating the value on resize ### How to 🎩 Load `indextable--small-screen-with-all-of-its-elements` on a large screen then resize to small. [Spin link](https://admin.web.am-test-it-ba.andrew-musgrave.us.spin.dev/store/shop1/orders?inContextTimeframe=none) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #6405
Fixes #4156
Fixes #5598
(it's the same bug, it is duplicated)
WHAT is this pull request doing?
It copies the mechanism on
ResourceListto keep the bulk actions visible on all screen sizes.Previous
Fixed
Does not affect bigger screens
