Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] Not rendered when entering from a disabled neighbor #1782

Closed
rexmac opened this issue Jul 4, 2019 · 1 comment · Fixed by #1783
Closed

[Tooltip] Not rendered when entering from a disabled neighbor #1782

rexmac opened this issue Jul 4, 2019 · 1 comment · Fixed by #1783
Assignees
Labels
Bug Something is broken and not working as intended in the system.

Comments

@rexmac
Copy link
Contributor

rexmac commented Jul 4, 2019

Issue summary

Official React bug report: facebook/react#10109

Expected behavior

Moving mouse from a disabled, <Tooltip />-wrapped button onto an enabled <Tooltip />-wrapped button should trigger the display of the active button's tooltip.

Actual behavior

The tooltip is not displayed. The following GIF shows an example of the bug:

polaris-pagination-tooltip-bug

Steps to reproduce the problem

Render two buttons side-by-side (e.g., the <Pagination /> component), disable one button, and wrap the other in a <Tooltip />.

Reduced test case

https://codesandbox.io/s/hopeful-moser-8242n

Specifications

  • Are you using the React components? (Y/N): Y
  • Polaris version number: 3.18.0
  • Browser: Chrome, Firefox (likely others)
  • Device: Macbook Pro
  • Operating System: macOS Mojave (10.14.5)
  System:
    OS: macOS 10.14.5
    CPU: x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 876.51 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 10.13.0 - ~/.nvm/versions/node/v10.13.0/bin/node
    Yarn: 1.13.0 - ~/.dev/yarn/v1.13.0/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.13.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Browsers:
    Chrome: 75.0.3770.100
    Firefox: 67.0
    Safari: 12.1.1
  npmPackages:
    react: ^16.4.0 => 16.4.0
    react-dom: ^16.4.0 => 16.4.0
@rexmac rexmac added the Bug Something is broken and not working as intended in the system. label Jul 4, 2019
@rexmac rexmac self-assigned this Jul 4, 2019
@ghost
Copy link

ghost commented Jul 4, 2019

👋 Thanks for opening your first issue. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack.

@rexmac rexmac changed the title [Pagination] [Tooltip] Tooltip not rendered when entering from a disabled neighbor [Tooltip] Not rendered when entering from a disabled neighbor Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
1 participant