Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page alignment broke in Polaris 1.2.1 #160

Closed
bakura10 opened this issue Jul 29, 2017 · 2 comments
Closed

Page alignment broke in Polaris 1.2.1 #160

bakura10 opened this issue Jul 29, 2017 · 2 comments

Comments

@bakura10
Copy link

Issue summary

Page with layout does not display appropriate padding.

Expected behavior

In Polaris 1.1.1, the page content had both a top and bottom margin:

capture d ecran 2017-07-29 a 14 53 55

After the switch to 1.2.1, the top margin has been removed, which introduce the whole content to be stuck to the top:

capture d ecran 2017-07-29 a 14 54 27

Specifications

  • Polaris version: 1.2.1
  • React version: 15.6
@dfmcphee
Copy link
Contributor

dfmcphee commented Aug 1, 2017

Thanks for the issue @bakura10. I have added this to our internal issue tracker and will update here when we have a fix.

@dfmcphee
Copy link
Contributor

This should be fixed in 1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants