Skip to content

Commit 9f9fe1f

Browse files
authored
[polaris.shopify.com] Fix overflow and no content bugs (#7400)
Fixes: #7399 Before / After (switches to after at ~20 second mark): https://user-images.githubusercontent.com/6844391/195714434-1407bb2f-85dd-40b7-ba91-734e2ef65366.mp4
1 parent 40ee692 commit 9f9fe1f

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

.changeset/green-cobras-call.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'polaris.shopify.com': patch
3+
---
4+
5+
Fixed a scaling bug caused by content overflow
6+
Fixed a bug where examples that don't have any content wouldn't show up

polaris.shopify.com/src/components/Frame/Frame.module.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ $breakpointNav: $breakpointTablet;
1919

2020
.NavAndContent {
2121
display: flex;
22+
overflow-wrap: anywhere;
2223
}
2324

2425
.PageContent {

polaris.shopify.com/src/components/PolarisExampleWrapper/PolarisExampleWrapper.module.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
align-items: center;
44
justify-content: center;
55
height: 100vh;
6-
padding-left: 16px;
7-
padding-right: 16px;
6+
padding-left: 32px;
7+
padding-right: 32px;
8+
}
9+
10+
.Example {
11+
width: 100%;
812
}

polaris.shopify.com/src/components/PolarisExampleWrapper/PolarisExampleWrapper.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export const withPolarisExample = (Component: ComponentType) => {
1313
<link rel="stylesheet" href={stylesheetHref} />
1414
<AppProvider i18n={translations}>
1515
<div className={styles.Container}>
16-
<div id="polaris-example">
16+
<div id="polaris-example" className={styles.Example}>
1717
<Component {...props} />
1818
</div>
1919
</div>

0 commit comments

Comments
 (0)