From eb472ae7d842c44ae424278eb1910b4cce594d3a Mon Sep 17 00:00:00 2001 From: Haskel Ash <105156770+haskelash-shopify@users.noreply.github.com> Date: Mon, 31 Oct 2022 16:12:25 +0200 Subject: [PATCH 1/4] BulkActions.tsx: deactivate popover if selectMode is false. --- polaris-react/src/components/BulkActions/BulkActions.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/polaris-react/src/components/BulkActions/BulkActions.tsx b/polaris-react/src/components/BulkActions/BulkActions.tsx index 5e2d63dbcd7..e20a223f1f9 100644 --- a/polaris-react/src/components/BulkActions/BulkActions.tsx +++ b/polaris-react/src/components/BulkActions/BulkActions.tsx @@ -298,7 +298,7 @@ class BulkActionsInner extends PureComponent { const allActionsPopover = this.hasActions() ? (
{ actionSections || rolledInPromotedActions.length > 0 || measuring ? (
Date: Wed, 2 Nov 2022 14:58:36 +0200 Subject: [PATCH 2/4] BulkActions.tsx: fix error of possible undefined. --- polaris-react/src/components/BulkActions/BulkActions.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/polaris-react/src/components/BulkActions/BulkActions.tsx b/polaris-react/src/components/BulkActions/BulkActions.tsx index e20a223f1f9..3678770e55e 100644 --- a/polaris-react/src/components/BulkActions/BulkActions.tsx +++ b/polaris-react/src/components/BulkActions/BulkActions.tsx @@ -298,7 +298,7 @@ class BulkActionsInner extends PureComponent { const allActionsPopover = this.hasActions() ? (
{ actionSections || rolledInPromotedActions.length > 0 || measuring ? (
Date: Wed, 2 Nov 2022 16:55:44 +0200 Subject: [PATCH 3/4] Create changeset. --- .changeset/chilled-otters-remember.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/chilled-otters-remember.md diff --git a/.changeset/chilled-otters-remember.md b/.changeset/chilled-otters-remember.md new file mode 100644 index 00000000000..7b2a29f4f0a --- /dev/null +++ b/.changeset/chilled-otters-remember.md @@ -0,0 +1,5 @@ +--- +'@shopify/polaris': patch +--- + +Hide bulk actions popup when all items are deselected. From e37a36d551616307632429819e13beb090e13229 Mon Sep 17 00:00:00 2001 From: Haskel Ash <105156770+haskelash-shopify@users.noreply.github.com> Date: Wed, 2 Nov 2022 17:11:51 +0200 Subject: [PATCH 4/4] BulkActions.tsx: use strict equality check. --- polaris-react/src/components/BulkActions/BulkActions.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/polaris-react/src/components/BulkActions/BulkActions.tsx b/polaris-react/src/components/BulkActions/BulkActions.tsx index 3678770e55e..0e603e5c19f 100644 --- a/polaris-react/src/components/BulkActions/BulkActions.tsx +++ b/polaris-react/src/components/BulkActions/BulkActions.tsx @@ -298,7 +298,7 @@ class BulkActionsInner extends PureComponent { const allActionsPopover = this.hasActions() ? (
{ actionSections || rolledInPromotedActions.length > 0 || measuring ? (