-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Layout foundations] Refactor token types #7296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aveline
merged 8 commits into
layout-foundations-prototype
from
layout-refactor-token-types
Sep 29, 2022
Merged
[Layout foundations] Refactor token types #7296
aveline
merged 8 commits into
layout-foundations-prototype
from
layout-refactor-token-types
Sep 29, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
04ee42a to
76d84e9
Compare
laurkim
approved these changes
Sep 29, 2022
Contributor
laurkim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! 💯 ![]()
chazdean
approved these changes
Sep 29, 2022
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! 🤩🛳
laurkim
pushed a commit
that referenced
this pull request
Sep 30, 2022
### WHY are these changes introduced? Fixes #7277 ### WHAT is this pull request doing? Pulls in token scales from `polaris-tokens` instead of adhoc creating them and duplicating the effort in various component files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #7277
WHAT is this pull request doing?
Pulls in token scales from
polaris-tokensinstead of adhoc creating them and duplicating the effort in various component files