Skip to content

Conversation

@aveline
Copy link
Contributor

@aveline aveline commented Sep 28, 2022

WHY are these changes introduced?

Fixes #7277

WHAT is this pull request doing?

Pulls in token scales from polaris-tokens instead of adhoc creating them and duplicating the effort in various component files

@aveline aveline changed the title Layout refactor token types [Layout foundations] Refactor token types Sep 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

size-limit report 📦

Path Size
polaris-react-cjs 204.72 KB (0%)
polaris-react-esm 131.16 KB (0%)
polaris-react-esnext 186.36 KB (0%)
polaris-react-css 41.37 KB (0%)

@aveline aveline marked this pull request as ready for review September 28, 2022 22:33
@laurkim laurkim force-pushed the layout-refactor-token-types branch from 04ee42a to 76d84e9 Compare September 29, 2022 16:21
Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 💯 :shipit:

Copy link
Contributor

@chazdean chazdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🤩🛳

@aveline aveline merged commit 5a7c86b into layout-foundations-prototype Sep 29, 2022
@aveline aveline deleted the layout-refactor-token-types branch September 29, 2022 19:11
laurkim pushed a commit that referenced this pull request Sep 30, 2022
### WHY are these changes introduced?

Fixes #7277

### WHAT is this pull request doing?

Pulls in token scales from `polaris-tokens` instead of adhoc creating
them and duplicating the effort in various component files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants