Update AlphaCard border radius to a boolean
#7287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @laurkim! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
laurkim
pushed a commit
that referenced
this pull request
Sep 30, 2022
### WHY are these changes introduced? Based on conversation around `Card` #7195 (comment) ### WHAT is this pull request doing? Border radius on the `AlphaCard` component is now a boolean so a card can either have no border radius or a border radius of `2` from the border radius token scale. No change to the responsive border radius behaviour, a card can switch from no border radius to border radius of `2` at a breakpoint that's passed in as a prop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Based on conversation around
Card#7195 (comment)WHAT is this pull request doing?
Border radius on the
AlphaCardcomponent is now a boolean so a card can either have no border radius or a border radius of2from the border radius token scale.No change to the responsive border radius behaviour, a card can switch from no border radius to border radius of
2at a breakpoint that's passed in as a prop.