Replace data/*.json files with build time .cache/site.json #7074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
commented
Sep 1, 2022
Comment on lines
+1
to
+8
| import path from 'path'; | ||
| import chokidar from 'chokidar'; | ||
|
|
||
| import genSiteJson from './gen-site-json.mjs'; | ||
|
|
||
| const mdPath = path.join(process.cwd(), 'content'); | ||
|
|
||
| chokidar.watch(mdPath).on('change', async () => await genSiteJson()); |
Member
Author
There was a problem hiding this comment.
This could probably be replaced with chokidar-cli. The downside is I would need a file that runs genSiteJson() which would look like...
import genSiteJson from './gen-site-json.mjs';
genSiteJson();So for now I just made a single file, happy to iterate on this later.
Merged
alex-page
pushed a commit
that referenced
this pull request
Sep 2, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#6890](#6890) [`267e1a9bd`](267e1a9) Thanks [@alex-page](https://github.com/alex-page)! - Add deprecated scss API to stylelint-polaris and use regex tests in the config ## @shopify/[email protected] ### Patch Changes - [#6840](#6840) [`90f325460`](90f3254) Thanks [@AndrewMusgrave](https://github.com/AndrewMusgrave)! - Removed additional reflows from IndexTable ## [email protected] ### Minor Changes - [#7074](#7074) [`ddfacd855`](ddfacd8) Thanks [@alex-page](https://github.com/alex-page)! - Replace data/\*.json files with build time .cache/site.json - [#7082](#7082) [`8ebb9fc3c`](8ebb9fc) Thanks [@selenehinkley](https://github.com/selenehinkley)! - Large edit of /contributing - [#7087](#7087) [`43ea7e5d5`](43ea7e5) Thanks [@alex-page](https://github.com/alex-page)! - Add automation to generate .cache/nav.json ### Patch Changes - [#7037](#7037) [`7dafdee00`](7dafdee) Thanks [@alex-page](https://github.com/alex-page)! - Move header logic to the API and out of next.config.js - [#7075](#7075) [`5933fc547`](5933fc5) Thanks [@alex-page](https://github.com/alex-page)! - Run gen-assets on build of website - Updated dependencies \[[`90f325460`](90f3254)]: - @shopify/[email protected] ## [email protected] ### Patch Changes - Updated dependencies \[[`90f325460`](90f3254)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
.cache/site.jsonfile making sure the navigation and search do not need to be updated when creating new pagescomponents.jsonandfoundations.jsonwith.cache/site.jsonreadFilescript needed to access it.cache/site.jsonfile regenerate on changes to markdown filesFuture work
.cache/site.jsonin client side memory when generating the navigation.cache/site.jsonin client side memory when generating the components page categories