Skip to content

Conversation

@laurkim
Copy link
Contributor

@laurkim laurkim commented Jul 22, 2022

WHY are these changes introduced?

Resolves #6724.

Display variants were intended to give clarity on how to apply type but ended up causing more confusion.

WHAT is this pull request doing?

Refactors the displaySm, displayMd, and displayLg variants to heading2xl, heading3xl, and heading4xl.

Storybook url.
Screenshot:


Updated Text component variants
Updated Text component variants

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';

import {Page, Stack, Text} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
      <Stack vertical>
        <Text as="h1" variant="heading4xl">
          Heading4xl variant
        </Text>
        <Text as="h2" variant="heading3xl">
          Heading3xl variant
        </Text>
        <Text as="h3" variant="heading2xl">
          Heading2xl variant
        </Text>
        <Text as="h4" variant="headingXl">
          HeadingXl variant
        </Text>
        <Text as="h5" variant="headingLg">
          HeadingLg variant
        </Text>
        <Text as="h6" variant="headingMd">
          HeadingMd variant
        </Text>
        <Text as="h6" variant="headingSm">
          HeadingSm variant
        </Text>
        <Text as="p" variant="bodyLg">
          BodyLg variant
        </Text>
        <Text as="p" variant="bodyMd">
          BodyMd variant
        </Text>
        <Text as="p" variant="bodySm">
          BodySm variant
        </Text>
      </Stack>
    </Page>
  );
}

🎩 checklist

@laurkim laurkim self-assigned this Jul 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022

size-limit report 📦

Path Size
polaris-react-cjs 198.78 KB (-0.01% 🔽)
polaris-react-esm 128.35 KB (+0.01% 🔺)
polaris-react-esnext 182.99 KB (0%)
polaris-react-css 41.1 KB (-0.01% 🔽)

@laurkim laurkim requested review from aveline, chazdean and sarahill July 22, 2022 12:10
@laurkim laurkim marked this pull request as ready for review July 22, 2022 12:11
@laurkim laurkim force-pushed the lo/refactor-display-variants branch from b2d7dfc to 90bd462 Compare July 22, 2022 15:52
@laurkim laurkim merged commit 7fd3fee into typography-foundations-text-component Jul 22, 2022
@laurkim laurkim deleted the lo/refactor-display-variants branch July 22, 2022 16:06
chazdean added a commit that referenced this pull request Jul 25, 2022
* Create README.md

* Add new Text component page

* Add Text component examples

* Add changeset

* Use existing changeset

* Update Syntax

* [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700)

* [Typography foundations] Add fontweight to Text variants (#6698)

* Update polaris-readme-loader.js

* Update README.md

* Update text.md

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris.shopify.com/src/data/components.json

Co-authored-by: Lo Kim <[email protected]>

* Update component example titles

* Update component example file names

* [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735)

* Create README.md

* Add new Text component page

* Add Text component examples

* Add changeset

* Use existing changeset

* Update Syntax

* Update polaris-readme-loader.js

* Update README.md

* Update text.md

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris.shopify.com/src/data/components.json

Co-authored-by: Lo Kim <[email protected]>

* Update component example titles

* Update component example file names

* Refactor `display` variants to `heading2xl-4xl`

* Update polaris.shopify.com/src/pages/examples/text-heading-4xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-3xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-2xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-extra-large.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-large.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-medium.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-small.tsx

Co-authored-by: Alex Page <[email protected]>

* Remove Text Display examples

Co-authored-by: Lo Kim <[email protected]>
Co-authored-by: Alex Page <[email protected]>
laurkim added a commit that referenced this pull request Jul 29, 2022
* Create README.md

* Add new Text component page

* Add Text component examples

* Add changeset

* Use existing changeset

* Update Syntax

* [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700)

* [Typography foundations] Add fontweight to Text variants (#6698)

* Update polaris-readme-loader.js

* Update README.md

* Update text.md

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris.shopify.com/src/data/components.json

Co-authored-by: Lo Kim <[email protected]>

* Update component example titles

* Update component example file names

* [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735)

* Create README.md

* Add new Text component page

* Add Text component examples

* Add changeset

* Use existing changeset

* Update Syntax

* Update polaris-readme-loader.js

* Update README.md

* Update text.md

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris.shopify.com/src/data/components.json

Co-authored-by: Lo Kim <[email protected]>

* Update component example titles

* Update component example file names

* Refactor `display` variants to `heading2xl-4xl`

* Update polaris.shopify.com/src/pages/examples/text-heading-4xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-3xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-2xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-extra-large.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-large.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-medium.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-small.tsx

Co-authored-by: Alex Page <[email protected]>

* Remove Text Display examples

Co-authored-by: Lo Kim <[email protected]>
Co-authored-by: Alex Page <[email protected]>
laurkim added a commit that referenced this pull request Jul 29, 2022
* Create README.md

* Add new Text component page

* Add Text component examples

* Add changeset

* Use existing changeset

* Update Syntax

* [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700)

* [Typography foundations] Add fontweight to Text variants (#6698)

* Update polaris-readme-loader.js

* Update README.md

* Update text.md

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris.shopify.com/src/data/components.json

Co-authored-by: Lo Kim <[email protected]>

* Update component example titles

* Update component example file names

* [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735)

* Create README.md

* Add new Text component page

* Add Text component examples

* Add changeset

* Use existing changeset

* Update Syntax

* Update polaris-readme-loader.js

* Update README.md

* Update text.md

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris.shopify.com/src/data/components.json

Co-authored-by: Lo Kim <[email protected]>

* Update component example titles

* Update component example file names

* Refactor `display` variants to `heading2xl-4xl`

* Update polaris.shopify.com/src/pages/examples/text-heading-4xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-3xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-2xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-extra-large.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-large.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-medium.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-small.tsx

Co-authored-by: Alex Page <[email protected]>

* Remove Text Display examples

Co-authored-by: Lo Kim <[email protected]>
Co-authored-by: Alex Page <[email protected]>
laurkim added a commit that referenced this pull request Jul 29, 2022
* [Typography foundations] Add Text component (#6521)

* [Typography foundations] Add Text component

Co-authored-by: Aveline Thelen <[email protected]>

* [Typography foundations] Add changeset

* [Typography foundations] Remove variant mapping

We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type.

* [Typography foundations] Clean up exports

* [Typography foundations] Add color options

* [Typography foundations] Add defaults for `as`/`variant` and make `as` required

* [Typography foundations] Add support for `visuallyHidden` prop

* [Typography foundations] Add prop descriptions

* [Typography foundations] Remove `a` as element type

* [Typography foundations] Make `variant` required prop

* [Typography foundations] Rename colors to align with tokens

Co-authored-by: Aveline Thelen <[email protected]>

* [Typography foundations] Update type scale and font size tokens (#6574)

* Update type scale and font size tokens

* Fix font size values

* Update line-height tokens

* Update token names

* Rename typography group to font

* Update `font` token group name

* [Typography foundations] Add support for code blocks with `InlineCode` component (#6623)

* [Typography foundations] Add support for `monospaced` variant and `InlineCode` component

* [Typography foundations] Update changeset

* [Typography foundations] Use new font tokens

* [Typography foundations] Remove InlineCode component

* [Typography foundations] Add `code` variant to `Text`

* [Typography foundations] Remove `text-style-body` mixin from AppProvider

The mixin was causing font-size issues for the Text `code` variation on Safari.

* [Typography foundations] Add InlineCode component and remove non-typographic styling from Text

Co-authored-by: Alex Page <[email protected]>

* [Typography foundations] Remove style changes from AppProvider

* Update changeset

* [Typography foundations] Update font-size in InlineCode

Co-authored-by: Alex Page <[email protected]>

* Update changeset

* [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700)

* [Typography foundations] Add fontweight to Text variants (#6698)

* [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735)

* [Typography foundations] Add `README` for new Text component (#6715)

* Create README.md

* Add new Text component page

* Add Text component examples

* Add changeset

* Use existing changeset

* Update Syntax

* [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700)

* [Typography foundations] Add fontweight to Text variants (#6698)

* Update polaris-readme-loader.js

* Update README.md

* Update text.md

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris.shopify.com/src/data/components.json

Co-authored-by: Lo Kim <[email protected]>

* Update component example titles

* Update component example file names

* [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735)

* Create README.md

* Add new Text component page

* Add Text component examples

* Add changeset

* Use existing changeset

* Update Syntax

* Update polaris-readme-loader.js

* Update README.md

* Update text.md

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris.shopify.com/src/data/components.json

Co-authored-by: Lo Kim <[email protected]>

* Update component example titles

* Update component example file names

* Refactor `display` variants to `heading2xl-4xl`

* Update polaris.shopify.com/src/pages/examples/text-heading-4xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-3xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-2xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-extra-large.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-large.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-medium.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-small.tsx

Co-authored-by: Alex Page <[email protected]>

* Remove Text Display examples

Co-authored-by: Lo Kim <[email protected]>
Co-authored-by: Alex Page <[email protected]>

* [Typography foundations] Add tests for `Text` and `InlineCode` components (#6747)

* [Typography foundations] Add tests for `Text` component

* [Typography foundations] Add tests for `InlineCode` component

* Add mappings for `DisplayText` to `Text` component `README` (#6702)

* Update `README` with mapping guidance

* Move text mappings to styleguide

* Add `VisuallyHidden` to `Text` mapping

Co-authored-by: Alex Page <[email protected]>

* Group text examples on styleguide (#6800)

* Group `Text` heading examples

* Group `Text` body examples

* Group `Text` align examples

* Group `font-weight` examples

* Group `color` text examples

* Update polaris.shopify.com/content/components/text.md

Co-authored-by: Sara Hill <[email protected]>

* Update polaris.shopify.com/content/components/text.md

Co-authored-by: Sara Hill <[email protected]>

* Update text color examples

* Update text weight examples order

Co-authored-by: Sara Hill <[email protected]>

* [Typography foundations] Feat/Update Text component to support Labels (#6797)

* Update Text.tsx

* Remove forced 'block' styling

* Delete changeset

* Resolve merge conflicts

* Fix references to `font` tokens

* Update font tokens in styleguide

* [Typography foundations] Fix outdated font size token

Co-authored-by: Aveline Thelen <[email protected]>
Co-authored-by: aveline <[email protected]>
Co-authored-by: Alex Page <[email protected]>
Co-authored-by: Chaz Dean <[email protected]>
Co-authored-by: Sara Hill <[email protected]>
laurkim added a commit that referenced this pull request Aug 23, 2022
* [Typography foundations] Add Text component (#6521)

* [Typography foundations] Add Text component

Co-authored-by: Aveline Thelen <[email protected]>

* [Typography foundations] Add changeset

* [Typography foundations] Remove variant mapping

We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type.

* [Typography foundations] Clean up exports

* [Typography foundations] Add color options

* [Typography foundations] Add defaults for `as`/`variant` and make `as` required

* [Typography foundations] Add support for `visuallyHidden` prop

* [Typography foundations] Add prop descriptions

* [Typography foundations] Remove `a` as element type

* [Typography foundations] Make `variant` required prop

* [Typography foundations] Rename colors to align with tokens

Co-authored-by: Aveline Thelen <[email protected]>

* [Typography foundations] Update type scale and font size tokens (#6574)

* Update type scale and font size tokens

* Fix font size values

* Update line-height tokens

* Update token names

* Rename typography group to font

* Update `font` token group name

* [Typography foundations] Add support for code blocks with `InlineCode` component (#6623)

* [Typography foundations] Add support for `monospaced` variant and `InlineCode` component

* [Typography foundations] Update changeset

* [Typography foundations] Use new font tokens

* [Typography foundations] Remove InlineCode component

* [Typography foundations] Add `code` variant to `Text`

* [Typography foundations] Remove `text-style-body` mixin from AppProvider

The mixin was causing font-size issues for the Text `code` variation on Safari.

* [Typography foundations] Add InlineCode component and remove non-typographic styling from Text

Co-authored-by: Alex Page <[email protected]>

* [Typography foundations] Remove style changes from AppProvider

* Update changeset

* [Typography foundations] Update font-size in InlineCode

Co-authored-by: Alex Page <[email protected]>

* Update changeset

* [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700)

* [Typography foundations] Add fontweight to Text variants (#6698)

* [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735)

* [Typography foundations] Add `README` for new Text component (#6715)

* Create README.md

* Add new Text component page

* Add Text component examples

* Add changeset

* Use existing changeset

* Update Syntax

* [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700)

* [Typography foundations] Add fontweight to Text variants (#6698)

* Update polaris-readme-loader.js

* Update README.md

* Update text.md

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris.shopify.com/src/data/components.json

Co-authored-by: Lo Kim <[email protected]>

* Update component example titles

* Update component example file names

* [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735)

* Create README.md

* Add new Text component page

* Add Text component examples

* Add changeset

* Use existing changeset

* Update Syntax

* Update polaris-readme-loader.js

* Update README.md

* Update text.md

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris-react/src/components/Text/README.md

Co-authored-by: Lo Kim <[email protected]>

* Update polaris.shopify.com/src/data/components.json

Co-authored-by: Lo Kim <[email protected]>

* Update component example titles

* Update component example file names

* Refactor `display` variants to `heading2xl-4xl`

* Update polaris.shopify.com/src/pages/examples/text-heading-4xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-3xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-2xl.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-extra-large.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-large.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-medium.tsx

Co-authored-by: Alex Page <[email protected]>

* Update polaris.shopify.com/src/pages/examples/text-heading-small.tsx

Co-authored-by: Alex Page <[email protected]>

* Remove Text Display examples

Co-authored-by: Lo Kim <[email protected]>
Co-authored-by: Alex Page <[email protected]>

* [Typography foundations] Add tests for `Text` and `InlineCode` components (#6747)

* [Typography foundations] Add tests for `Text` component

* [Typography foundations] Add tests for `InlineCode` component

* Add mappings for `DisplayText` to `Text` component `README` (#6702)

* Update `README` with mapping guidance

* Move text mappings to styleguide

* Add `VisuallyHidden` to `Text` mapping

Co-authored-by: Alex Page <[email protected]>

* Group text examples on styleguide (#6800)

* Group `Text` heading examples

* Group `Text` body examples

* Group `Text` align examples

* Group `font-weight` examples

* Group `color` text examples

* Update polaris.shopify.com/content/components/text.md

Co-authored-by: Sara Hill <[email protected]>

* Update polaris.shopify.com/content/components/text.md

Co-authored-by: Sara Hill <[email protected]>

* Update text color examples

* Update text weight examples order

Co-authored-by: Sara Hill <[email protected]>

* [Typography foundations] Feat/Update Text component to support Labels (#6797)

* Update Text.tsx

* Remove forced 'block' styling

* Delete changeset

* Resolve merge conflicts

* Fix references to `font` tokens

* Update font tokens in styleguide

* [Typography foundations] Fix outdated font size token

Co-authored-by: Aveline Thelen <[email protected]>
Co-authored-by: aveline <[email protected]>
Co-authored-by: Alex Page <[email protected]>
Co-authored-by: Chaz Dean <[email protected]>
Co-authored-by: Sara Hill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants