-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Typography foundations] Release alpha Text component #6572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
a3a40bb to
0281d22
Compare
5a60c65 to
7de0596
Compare
dc2fb62 to
6ad7601
Compare
|
/snapit |
|
🫰✨ Thanks @chazdean! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
|
/snapit |
|
🫰✨ Thanks @aveline! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
|
Failure re: |
5e90fe1 to
f142efb
Compare
* [Typography foundations] Add Text component Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Add changeset * [Typography foundations] Remove variant mapping We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type. * [Typography foundations] Clean up exports * [Typography foundations] Add color options * [Typography foundations] Add defaults for `as`/`variant` and make `as` required * [Typography foundations] Add support for `visuallyHidden` prop * [Typography foundations] Add prop descriptions * [Typography foundations] Remove `a` as element type * [Typography foundations] Make `variant` required prop * [Typography foundations] Rename colors to align with tokens Co-authored-by: Aveline Thelen <[email protected]>
* Update type scale and font size tokens * Fix font size values * Update line-height tokens * Update token names * Rename typography group to font * Update `font` token group name
…` component (#6623) * [Typography foundations] Add support for `monospaced` variant and `InlineCode` component * [Typography foundations] Update changeset * [Typography foundations] Use new font tokens * [Typography foundations] Remove InlineCode component * [Typography foundations] Add `code` variant to `Text` * [Typography foundations] Remove `text-style-body` mixin from AppProvider The mixin was causing font-size issues for the Text `code` variation on Safari. * [Typography foundations] Add InlineCode component and remove non-typographic styling from Text Co-authored-by: Alex Page <[email protected]> * [Typography foundations] Remove style changes from AppProvider * Update changeset * [Typography foundations] Update font-size in InlineCode Co-authored-by: Alex Page <[email protected]>
* Create README.md * Add new Text component page * Add Text component examples * Add changeset * Use existing changeset * Update Syntax * [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700) * [Typography foundations] Add fontweight to Text variants (#6698) * Update polaris-readme-loader.js * Update README.md * Update text.md * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris.shopify.com/src/data/components.json Co-authored-by: Lo Kim <[email protected]> * Update component example titles * Update component example file names * [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735) * Create README.md * Add new Text component page * Add Text component examples * Add changeset * Use existing changeset * Update Syntax * Update polaris-readme-loader.js * Update README.md * Update text.md * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris.shopify.com/src/data/components.json Co-authored-by: Lo Kim <[email protected]> * Update component example titles * Update component example file names * Refactor `display` variants to `heading2xl-4xl` * Update polaris.shopify.com/src/pages/examples/text-heading-4xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-3xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-2xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-extra-large.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-large.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-medium.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-small.tsx Co-authored-by: Alex Page <[email protected]> * Remove Text Display examples Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Alex Page <[email protected]>
…ents (#6747) * [Typography foundations] Add tests for `Text` component * [Typography foundations] Add tests for `InlineCode` component
* Update `README` with mapping guidance * Move text mappings to styleguide * Add `VisuallyHidden` to `Text` mapping Co-authored-by: Alex Page <[email protected]>
* Group `Text` heading examples * Group `Text` body examples * Group `Text` align examples * Group `font-weight` examples * Group `color` text examples * Update polaris.shopify.com/content/components/text.md Co-authored-by: Sara Hill <[email protected]> * Update polaris.shopify.com/content/components/text.md Co-authored-by: Sara Hill <[email protected]> * Update text color examples * Update text weight examples order Co-authored-by: Sara Hill <[email protected]>
…#6797) * Update Text.tsx * Remove forced 'block' styling * Delete changeset
f142efb to
6339164
Compare
This reverts commit c9c940c.
* [Typography foundations] Add Text component (#6521) * [Typography foundations] Add Text component Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Add changeset * [Typography foundations] Remove variant mapping We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type. * [Typography foundations] Clean up exports * [Typography foundations] Add color options * [Typography foundations] Add defaults for `as`/`variant` and make `as` required * [Typography foundations] Add support for `visuallyHidden` prop * [Typography foundations] Add prop descriptions * [Typography foundations] Remove `a` as element type * [Typography foundations] Make `variant` required prop * [Typography foundations] Rename colors to align with tokens Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Update type scale and font size tokens (#6574) * Update type scale and font size tokens * Fix font size values * Update line-height tokens * Update token names * Rename typography group to font * Update `font` token group name * [Typography foundations] Add support for code blocks with `InlineCode` component (#6623) * [Typography foundations] Add support for `monospaced` variant and `InlineCode` component * [Typography foundations] Update changeset * [Typography foundations] Use new font tokens * [Typography foundations] Remove InlineCode component * [Typography foundations] Add `code` variant to `Text` * [Typography foundations] Remove `text-style-body` mixin from AppProvider The mixin was causing font-size issues for the Text `code` variation on Safari. * [Typography foundations] Add InlineCode component and remove non-typographic styling from Text Co-authored-by: Alex Page <[email protected]> * [Typography foundations] Remove style changes from AppProvider * Update changeset * [Typography foundations] Update font-size in InlineCode Co-authored-by: Alex Page <[email protected]> * Update changeset * [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700) * [Typography foundations] Add fontweight to Text variants (#6698) * [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735) * [Typography foundations] Add `README` for new Text component (#6715) * Create README.md * Add new Text component page * Add Text component examples * Add changeset * Use existing changeset * Update Syntax * [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700) * [Typography foundations] Add fontweight to Text variants (#6698) * Update polaris-readme-loader.js * Update README.md * Update text.md * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris.shopify.com/src/data/components.json Co-authored-by: Lo Kim <[email protected]> * Update component example titles * Update component example file names * [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735) * Create README.md * Add new Text component page * Add Text component examples * Add changeset * Use existing changeset * Update Syntax * Update polaris-readme-loader.js * Update README.md * Update text.md * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris.shopify.com/src/data/components.json Co-authored-by: Lo Kim <[email protected]> * Update component example titles * Update component example file names * Refactor `display` variants to `heading2xl-4xl` * Update polaris.shopify.com/src/pages/examples/text-heading-4xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-3xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-2xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-extra-large.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-large.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-medium.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-small.tsx Co-authored-by: Alex Page <[email protected]> * Remove Text Display examples Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Alex Page <[email protected]> * [Typography foundations] Add tests for `Text` and `InlineCode` components (#6747) * [Typography foundations] Add tests for `Text` component * [Typography foundations] Add tests for `InlineCode` component * Add mappings for `DisplayText` to `Text` component `README` (#6702) * Update `README` with mapping guidance * Move text mappings to styleguide * Add `VisuallyHidden` to `Text` mapping Co-authored-by: Alex Page <[email protected]> * Group text examples on styleguide (#6800) * Group `Text` heading examples * Group `Text` body examples * Group `Text` align examples * Group `font-weight` examples * Group `color` text examples * Update polaris.shopify.com/content/components/text.md Co-authored-by: Sara Hill <[email protected]> * Update polaris.shopify.com/content/components/text.md Co-authored-by: Sara Hill <[email protected]> * Update text color examples * Update text weight examples order Co-authored-by: Sara Hill <[email protected]> * [Typography foundations] Feat/Update Text component to support Labels (#6797) * Update Text.tsx * Remove forced 'block' styling * Delete changeset * Resolve merge conflicts * Fix references to `font` tokens * Update font tokens in styleguide * [Typography foundations] Fix outdated font size token Co-authored-by: Aveline Thelen <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Chaz Dean <[email protected]> Co-authored-by: Sara Hill <[email protected]>
Typography foundations feature branch for alpha release.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes