-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Typography foundations] Add Text component #6521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
laurkim
merged 11 commits into
typography-foundations-text-component
from
lo/add-text-component
Jul 8, 2022
Merged
[Typography foundations] Add Text component #6521
laurkim
merged 11 commits into
typography-foundations-text-component
from
lo/add-text-component
Jul 8, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
4bd9835 to
2ee92d7
Compare
3b4d4cc to
0db9488
Compare
Co-authored-by: Aveline Thelen <[email protected]>
We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type.
47c6738 to
1a31bcd
Compare
aveline
approved these changes
Jul 8, 2022
Contributor
aveline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
chazdean
approved these changes
Jul 8, 2022
laurkim
added a commit
that referenced
this pull request
Jul 20, 2022
* [Typography foundations] Add Text component Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Add changeset * [Typography foundations] Remove variant mapping We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type. * [Typography foundations] Clean up exports * [Typography foundations] Add color options * [Typography foundations] Add defaults for `as`/`variant` and make `as` required * [Typography foundations] Add support for `visuallyHidden` prop * [Typography foundations] Add prop descriptions * [Typography foundations] Remove `a` as element type * [Typography foundations] Make `variant` required prop * [Typography foundations] Rename colors to align with tokens Co-authored-by: Aveline Thelen <[email protected]>
laurkim
added a commit
that referenced
this pull request
Jul 20, 2022
* [Typography foundations] Add Text component Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Add changeset * [Typography foundations] Remove variant mapping We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type. * [Typography foundations] Clean up exports * [Typography foundations] Add color options * [Typography foundations] Add defaults for `as`/`variant` and make `as` required * [Typography foundations] Add support for `visuallyHidden` prop * [Typography foundations] Add prop descriptions * [Typography foundations] Remove `a` as element type * [Typography foundations] Make `variant` required prop * [Typography foundations] Rename colors to align with tokens Co-authored-by: Aveline Thelen <[email protected]>
laurkim
added a commit
that referenced
this pull request
Jul 20, 2022
* [Typography foundations] Add Text component Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Add changeset * [Typography foundations] Remove variant mapping We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type. * [Typography foundations] Clean up exports * [Typography foundations] Add color options * [Typography foundations] Add defaults for `as`/`variant` and make `as` required * [Typography foundations] Add support for `visuallyHidden` prop * [Typography foundations] Add prop descriptions * [Typography foundations] Remove `a` as element type * [Typography foundations] Make `variant` required prop * [Typography foundations] Rename colors to align with tokens Co-authored-by: Aveline Thelen <[email protected]>
laurkim
added a commit
that referenced
this pull request
Jul 29, 2022
* [Typography foundations] Add Text component Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Add changeset * [Typography foundations] Remove variant mapping We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type. * [Typography foundations] Clean up exports * [Typography foundations] Add color options * [Typography foundations] Add defaults for `as`/`variant` and make `as` required * [Typography foundations] Add support for `visuallyHidden` prop * [Typography foundations] Add prop descriptions * [Typography foundations] Remove `a` as element type * [Typography foundations] Make `variant` required prop * [Typography foundations] Rename colors to align with tokens Co-authored-by: Aveline Thelen <[email protected]>
laurkim
added a commit
that referenced
this pull request
Jul 29, 2022
* [Typography foundations] Add Text component Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Add changeset * [Typography foundations] Remove variant mapping We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type. * [Typography foundations] Clean up exports * [Typography foundations] Add color options * [Typography foundations] Add defaults for `as`/`variant` and make `as` required * [Typography foundations] Add support for `visuallyHidden` prop * [Typography foundations] Add prop descriptions * [Typography foundations] Remove `a` as element type * [Typography foundations] Make `variant` required prop * [Typography foundations] Rename colors to align with tokens Co-authored-by: Aveline Thelen <[email protected]>
laurkim
added a commit
that referenced
this pull request
Jul 29, 2022
* [Typography foundations] Add Text component (#6521) * [Typography foundations] Add Text component Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Add changeset * [Typography foundations] Remove variant mapping We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type. * [Typography foundations] Clean up exports * [Typography foundations] Add color options * [Typography foundations] Add defaults for `as`/`variant` and make `as` required * [Typography foundations] Add support for `visuallyHidden` prop * [Typography foundations] Add prop descriptions * [Typography foundations] Remove `a` as element type * [Typography foundations] Make `variant` required prop * [Typography foundations] Rename colors to align with tokens Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Update type scale and font size tokens (#6574) * Update type scale and font size tokens * Fix font size values * Update line-height tokens * Update token names * Rename typography group to font * Update `font` token group name * [Typography foundations] Add support for code blocks with `InlineCode` component (#6623) * [Typography foundations] Add support for `monospaced` variant and `InlineCode` component * [Typography foundations] Update changeset * [Typography foundations] Use new font tokens * [Typography foundations] Remove InlineCode component * [Typography foundations] Add `code` variant to `Text` * [Typography foundations] Remove `text-style-body` mixin from AppProvider The mixin was causing font-size issues for the Text `code` variation on Safari. * [Typography foundations] Add InlineCode component and remove non-typographic styling from Text Co-authored-by: Alex Page <[email protected]> * [Typography foundations] Remove style changes from AppProvider * Update changeset * [Typography foundations] Update font-size in InlineCode Co-authored-by: Alex Page <[email protected]> * Update changeset * [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700) * [Typography foundations] Add fontweight to Text variants (#6698) * [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735) * [Typography foundations] Add `README` for new Text component (#6715) * Create README.md * Add new Text component page * Add Text component examples * Add changeset * Use existing changeset * Update Syntax * [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700) * [Typography foundations] Add fontweight to Text variants (#6698) * Update polaris-readme-loader.js * Update README.md * Update text.md * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris.shopify.com/src/data/components.json Co-authored-by: Lo Kim <[email protected]> * Update component example titles * Update component example file names * [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735) * Create README.md * Add new Text component page * Add Text component examples * Add changeset * Use existing changeset * Update Syntax * Update polaris-readme-loader.js * Update README.md * Update text.md * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris.shopify.com/src/data/components.json Co-authored-by: Lo Kim <[email protected]> * Update component example titles * Update component example file names * Refactor `display` variants to `heading2xl-4xl` * Update polaris.shopify.com/src/pages/examples/text-heading-4xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-3xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-2xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-extra-large.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-large.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-medium.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-small.tsx Co-authored-by: Alex Page <[email protected]> * Remove Text Display examples Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Alex Page <[email protected]> * [Typography foundations] Add tests for `Text` and `InlineCode` components (#6747) * [Typography foundations] Add tests for `Text` component * [Typography foundations] Add tests for `InlineCode` component * Add mappings for `DisplayText` to `Text` component `README` (#6702) * Update `README` with mapping guidance * Move text mappings to styleguide * Add `VisuallyHidden` to `Text` mapping Co-authored-by: Alex Page <[email protected]> * Group text examples on styleguide (#6800) * Group `Text` heading examples * Group `Text` body examples * Group `Text` align examples * Group `font-weight` examples * Group `color` text examples * Update polaris.shopify.com/content/components/text.md Co-authored-by: Sara Hill <[email protected]> * Update polaris.shopify.com/content/components/text.md Co-authored-by: Sara Hill <[email protected]> * Update text color examples * Update text weight examples order Co-authored-by: Sara Hill <[email protected]> * [Typography foundations] Feat/Update Text component to support Labels (#6797) * Update Text.tsx * Remove forced 'block' styling * Delete changeset * Resolve merge conflicts * Fix references to `font` tokens * Update font tokens in styleguide * [Typography foundations] Fix outdated font size token Co-authored-by: Aveline Thelen <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Chaz Dean <[email protected]> Co-authored-by: Sara Hill <[email protected]>
laurkim
added a commit
that referenced
this pull request
Aug 23, 2022
* [Typography foundations] Add Text component (#6521) * [Typography foundations] Add Text component Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Add changeset * [Typography foundations] Remove variant mapping We expect users to determine element type even if `variant` is passed in, so as to decouple styling from element type. * [Typography foundations] Clean up exports * [Typography foundations] Add color options * [Typography foundations] Add defaults for `as`/`variant` and make `as` required * [Typography foundations] Add support for `visuallyHidden` prop * [Typography foundations] Add prop descriptions * [Typography foundations] Remove `a` as element type * [Typography foundations] Make `variant` required prop * [Typography foundations] Rename colors to align with tokens Co-authored-by: Aveline Thelen <[email protected]> * [Typography foundations] Update type scale and font size tokens (#6574) * Update type scale and font size tokens * Fix font size values * Update line-height tokens * Update token names * Rename typography group to font * Update `font` token group name * [Typography foundations] Add support for code blocks with `InlineCode` component (#6623) * [Typography foundations] Add support for `monospaced` variant and `InlineCode` component * [Typography foundations] Update changeset * [Typography foundations] Use new font tokens * [Typography foundations] Remove InlineCode component * [Typography foundations] Add `code` variant to `Text` * [Typography foundations] Remove `text-style-body` mixin from AppProvider The mixin was causing font-size issues for the Text `code` variation on Safari. * [Typography foundations] Add InlineCode component and remove non-typographic styling from Text Co-authored-by: Alex Page <[email protected]> * [Typography foundations] Remove style changes from AppProvider * Update changeset * [Typography foundations] Update font-size in InlineCode Co-authored-by: Alex Page <[email protected]> * Update changeset * [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700) * [Typography foundations] Add fontweight to Text variants (#6698) * [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735) * [Typography foundations] Add `README` for new Text component (#6715) * Create README.md * Add new Text component page * Add Text component examples * Add changeset * Use existing changeset * Update Syntax * [Typography foundations] Update `<InlineCode>` styling for accessibility (#6700) * [Typography foundations] Add fontweight to Text variants (#6698) * Update polaris-readme-loader.js * Update README.md * Update text.md * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris.shopify.com/src/data/components.json Co-authored-by: Lo Kim <[email protected]> * Update component example titles * Update component example file names * [Typography foundations] Refactor `display` variants to `heading2xl-4xl` (#6735) * Create README.md * Add new Text component page * Add Text component examples * Add changeset * Use existing changeset * Update Syntax * Update polaris-readme-loader.js * Update README.md * Update text.md * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris-react/src/components/Text/README.md Co-authored-by: Lo Kim <[email protected]> * Update polaris.shopify.com/src/data/components.json Co-authored-by: Lo Kim <[email protected]> * Update component example titles * Update component example file names * Refactor `display` variants to `heading2xl-4xl` * Update polaris.shopify.com/src/pages/examples/text-heading-4xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-3xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-2xl.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-extra-large.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-large.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-medium.tsx Co-authored-by: Alex Page <[email protected]> * Update polaris.shopify.com/src/pages/examples/text-heading-small.tsx Co-authored-by: Alex Page <[email protected]> * Remove Text Display examples Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Alex Page <[email protected]> * [Typography foundations] Add tests for `Text` and `InlineCode` components (#6747) * [Typography foundations] Add tests for `Text` component * [Typography foundations] Add tests for `InlineCode` component * Add mappings for `DisplayText` to `Text` component `README` (#6702) * Update `README` with mapping guidance * Move text mappings to styleguide * Add `VisuallyHidden` to `Text` mapping Co-authored-by: Alex Page <[email protected]> * Group text examples on styleguide (#6800) * Group `Text` heading examples * Group `Text` body examples * Group `Text` align examples * Group `font-weight` examples * Group `color` text examples * Update polaris.shopify.com/content/components/text.md Co-authored-by: Sara Hill <[email protected]> * Update polaris.shopify.com/content/components/text.md Co-authored-by: Sara Hill <[email protected]> * Update text color examples * Update text weight examples order Co-authored-by: Sara Hill <[email protected]> * [Typography foundations] Feat/Update Text component to support Labels (#6797) * Update Text.tsx * Remove forced 'block' styling * Delete changeset * Resolve merge conflicts * Fix references to `font` tokens * Update font tokens in styleguide * [Typography foundations] Fix outdated font size token Co-authored-by: Aveline Thelen <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Alex Page <[email protected]> Co-authored-by: Chaz Dean <[email protected]> Co-authored-by: Sara Hill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #6509, #6565.
To do:
Determine defaultmakeas->'p'asrequiredDetermine default style/variant ->make'bodyMd'variantrequiredTextStylecolorAddto be done in subsequent prmonospacevariant to mimic text style fromcodevariation onTextStyleCreate new component (i.e., InlineCode) to mimic style fromto be done in subsequent prcodevariation onTextStyleVisuallyHiddencomponent (?)WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes