Skip to content

Commit 8a05e84

Browse files
author
Gui Santos
authored
fix: decrease side padding of token nav buttons (#7452)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? We have a visual bug in production where the text in the token navigation breaks in a weird way <img width="1169" alt="Screenshot 2022-10-19 at 17 48 17" src="https://user-images.githubusercontent.com/6597467/196741993-cdb4d437-1485-4bf7-ab21-5af213b78843.png"> ### WHAT is this pull request doing? It decreases the side padding of the buttons in the Token's nav bar so the text does not break in a weird way <img width="1157" alt="Screenshot 2022-10-19 at 17 48 09" src="https://user-images.githubusercontent.com/6597467/196742062-e9b92371-c0cd-4565-93b2-16acf0402870.png"> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
1 parent 3191d13 commit 8a05e84

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'polaris.shopify.com': patch
3+
---
4+
5+
fix visual bug in token page's navigation where text was breaking into two lines

polaris.shopify.com/src/components/TokensPage/TokensPage.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
}
4141

4242
a {
43-
padding: 0.75rem 2rem;
43+
padding: 0.75rem 1rem;
4444
display: block;
4545
color: var(--text-strong);
4646
border-right: 1px solid var(--border-color);

0 commit comments

Comments
 (0)