-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.14 to CI #461
Add 1.14 to CI #461
Conversation
This is unlikely to pass 1.14 CI w/o #460 |
True, but it is currently failing during setup, so looks like we have other work to do |
Yep, was hoping it would just work, but not at all surprised. |
Would you mind pasting the other failures here? |
#460 was merged. This PR is just to enable 1.14 runs on our internal CI. The failures aren't related to the code in this repo, we just haven't added support for 1.14 to our CI. I'm trying to find some time to look at this, but I don't think it's blocking anything, we just don't have as much coverage as we'd like for now. |
b713126
to
ae9b91b
Compare
@dturn since I can't request you for a review on a PR you opened 😄 |
I think we actually need to keep running 1.10 for a bit longer. |
I'll do that in a separate PR. Cleaning this up shortly. |
Co-authored-by: Danny Turner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back to your original cut of this.
I'll re-run CI shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't officially approve a PR I opened but ✅ from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What are you trying to accomplish with this PR?
Support the latest k8s release.
How is this accomplished?
Adding it to ci
What could go wrong?
Not much, its just CI instructions