-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insure that any resource that is prunable can be pruned #326
Conversation
It looks like the apply issue has been resolved: kubernetes/kubernetes#53379 Think we should support pruning on replaceable resources? |
If I'm remembering correctly, the Looks like we still need |
84d87b3
to
0a961ba
Compare
@Shopify/cloudx 👀 please |
0a961ba
to
cf2271b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Statefulservice
still hasreplace
in it- Please make sure to 🎩 the branch before merging by locally deploying a test app with multiple Shopify CRs to a cluster that actually supports them. Make sure to try a deploy that includes a change to the CR's spec (i.e. do a deploy that would have actually triggered the bug we were working around with
:replace
). There is pretty much zero test coverage for those files because our controllers are not deployed in CI (yet another reason to get rid of them in favour of the dynamic feature!).
This was intentional. I was unsure why SS are |
🎩 with cloud-portal in the staging cluster by increasing & decreasing redis size. Let me know if you want to other resources. |
Are you thinking StatefulSet rather than StatefulService, perhaps? StatefulSet are a core resource and are already applied; StatefulService are CRs and were replaced for the same reason as the others. Confusing naming for sure.
I'd suggest testing a change with a more complicated patch just in case. For example. a change inside an array or a hash (I'm actually curious which strategy it uses by default... for core resources it is field-specific). ES probably has the most elaborate schema, and cumulus-cat has one so could be a good target for testing. |
Yep I definitely got StatefulService confused with StatefulSet I'll 🎩 something more complicated after fixing up StatefulSet |
🎩 a more complicated change went smoothly. |
Ready for final 👀 |
🚢 |
Resources with
deploy_method
replace*
don't go through an apply cycle. Since pruning happens in the apply cycle, they are never pruned. Ensure that everything that is prunable can actually be pruned.Allow PDBs to be pruned too
#279