You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The actual restart task doesn't match our standard interface convention. Please change perform/perform! to run/run! as well as ensure that new & run use the same conventions as the other tasks, its fine to do this in a separate PR.
Possible solution
Build a thor task that calls RestartTask.new.
Alternative solutions
Depending on the difficulty of supporting --verify-result=false this may need to be split into a second PR. We've discussed adding a new command that can stand alone verify a namespace, if a second PR is required please do it with an eye towards supporting such a command.
The initial pass was added in 548. We still need to support the -f` flag. Thor merged rails/thor#674 (allow repeatable options), but they haven't cut a release, depending on the timeline we may point at a sha.
Problem
Add the
krane restart
command, https://docs.google.com/document/d/1oInUsKplYGNWTymPY48xtDCx3x4Cwc-phcEKUkt2v4U/view# has details on flags that need to be supported.This is blocked by #524.
The actual restart task doesn't match our standard interface convention. Please change
perform/perform!
torun/run!
as well as ensure thatnew
&run
use the same conventions as the other tasks, its fine to do this in a separate PR.Possible solution
Build a thor task that calls RestartTask.new.
Alternative solutions
Depending on the difficulty of supporting
--verify-result=false
this may need to be split into a second PR. We've discussed adding a new command that can stand alone verify a namespace, if a second PR is required please do it with an eye towards supporting such a command.Acceptance criteria
Additional context
#256 is the tracking issue for the new CLI.
The text was updated successfully, but these errors were encountered: