Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate nodes returned in 2023-04 and unstable, fine in 2023-01 #764

Closed
duncan-fairley opened this issue Apr 6, 2023 · 3 comments
Closed
Labels
Bug Something isn't working

Comments

@duncan-fairley
Copy link
Contributor

What is the location of your example repository?

No response

Which package or tool is having this issue?

Storefront API

What version of that package or tool are you using?

2023-04

What version of Remix are you using?

No response

Steps to Reproduce

The following query, when called against 2023-04 and unstable:

  query {
    metaobjects(first: 4, type: "shops") {
      nodes {
        id
      }
    }
  }

returns two of each metaobject (request ID: 14010230-6cba-4287-88d7-28d7d02587b1):

{
   "data": {
      "metaobjects": {
         "nodes": [
            {
               "id": "gid://shopify/Metaobject/24543329"
            },
            {
               "id": "gid://shopify/Metaobject/24543329"
            },
            {
               "id": "gid://shopify/Metaobject/24576097"
            },
            {
               "id": "gid://shopify/Metaobject/24576097"
            }
         ]
      }
   }
}

Expected Behavior

This request returns correctly on 2023-01 (request ID: d28799fb-e1e9-4e7a-a13a-de97b9f43391)

{
   "data": {
      "metaobjects": {
         "nodes": [
            {
               "id": "gid://shopify/Metaobject/24543329"
            },
            {
               "id": "gid://shopify/Metaobject/24576097"
            },
            {
               "id": "gid://shopify/Metaobject/24608865"
            },
            {
               "id": "gid://shopify/Metaobject/24641633"
            }
         ]
      }
   }
}

This is creating issues on a few live sites that are built to expect uniqueness

Actual Behavior

Too much of a good thing!

@juanpprieto
Copy link
Contributor

Thanks @DuncanFa - reporting this internally with the SFAPI team

@duncan-fairley
Copy link
Contributor Author

Thanks @juanpprieto! Seeing it consistently across all Hydrogen storefronts using 2023-04

@juanpprieto juanpprieto added the Bug Something isn't working label Apr 6, 2023
@juanpprieto
Copy link
Contributor

Fixed. Thanks for letting us know @DuncanFa 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants