-
Notifications
You must be signed in to change notification settings - Fork 364
Update to TS5 #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Update to TS5 #1240
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6553522
Update to TS 5
frandiox d9adeac
Regenerate schema and fix minor issues
frandiox 4d7c93e
Fix hydrogen-react types for TS 5
frandiox ed86c8b
Enable TS type unit test
frandiox 9440b1d
Changesets
frandiox 1b84dfb
Fix missing typeof
frandiox b5d0720
Update changeset
frandiox 79494ae
Import CJS libraries lazily to improve startup time
frandiox 8b54677
Merge branch '2023-07' into fd-ts5-v2
frandiox 12c4cfb
Fix package-lock
frandiox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| '@shopify/hydrogen-react': patch | ||
| '@shopify/cli-hydrogen': patch | ||
| 'demo-store': patch | ||
| --- | ||
|
|
||
| Update to TypeScript 5. If you have `typescript` as a dev dependency in your app, change its version as follows: | ||
|
|
||
| ```diff | ||
| "devDependencies": { | ||
| ... | ||
| - "typescript": "^4.9.5", | ||
| + "typescript": "^5.1.6", | ||
| }, | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if the type fixes are still compatible with TS 4? Is moving to TS 5 a requirement if we merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it works in TS4 as well. These are just generic fixes we needed but TS4 was not catching.
For example, see a prop like
measurementshould throw a TS error but it wasn't doing it before (it does now): https://github.com/Shopify/hydrogen/pull/1240/files#r1297221747TS5 is not a requirement but, since the CLI installs it for tarnspiling stuff, it's better to update projects and avoid dependency duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reworded the changeset to make this more clear and also explained how to change the TS version in VSCode 👍