Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Component Work #627

Closed
elisenyang opened this issue Oct 25, 2022 · 4 comments
Closed

Image Component Work #627

elisenyang opened this issue Oct 25, 2022 · 4 comments
Assignees
@benjaminsehl
Labels
@shopify/hydrogen-react

Comments

@elisenyang
Copy link
Contributor

elisenyang commented Oct 25, 2022 •
edited
Loading

https://github.com/Shopify/hydrogen-ui/issues/44#tasklist-block-d0f9b244-6d22-4879-945d-d262299fccf9
@frehner
Copy link
Contributor

frehner commented Oct 31, 2022

I would add: export our Image loader() for e.g. NextJS

@elisenyang elisenyang changed the title Image Component Re-Design Image Component Work Nov 3, 2022
@elisenyang
Copy link
Contributor Author

We should also look at other framework, see which don't have their own Image component and can benefit from ours, and make any optimizations.

@frehner frehner transferred this issue from Shopify/hydrogen-react Mar 3, 2023
@benjaminsehl
Copy link
Member

Will be closed by #649

Re: Above — 

  1. Nothing specific in my component to Remix, and with the exception of React.createElement — nothing is React specific either.
  2. Loader is exported, but would be great to validate that it works in Next.js

@benjaminsehl
Copy link
Member

Closed by #787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminsehl benjaminsehl

Labels
@shopify/hydrogen-react
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benjaminsehl @frehner @elisenyang