From 5070a3928069ad2066bd1f3c8cbea8a0459bb524 Mon Sep 17 00:00:00 2001 From: Benjamin Sehl Date: Mon, 29 May 2023 11:07:57 -0400 Subject: [PATCH] Adds changeset --- .changeset/short-frogs-obey.md | 5 +++++ docs/docs/tutorials/configuration/index.md | 2 +- packages/hydrogen/src/entry-server.tsx | 2 +- .../playground/server-components/tests/e2e-test-cases.ts | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/short-frogs-obey.md diff --git a/.changeset/short-frogs-obey.md b/.changeset/short-frogs-obey.md new file mode 100644 index 0000000000..aa17af1fe1 --- /dev/null +++ b/.changeset/short-frogs-obey.md @@ -0,0 +1,5 @@ +--- +'@shopify/hydrogen': minor +--- + +Updates default `powered-by` header output to `Shopify, Hydrogen`, and updates associateed documentation. diff --git a/docs/docs/tutorials/configuration/index.md b/docs/docs/tutorials/configuration/index.md index 810e745ff7..3ab14b8485 100644 --- a/docs/docs/tutorials/configuration/index.md +++ b/docs/docs/tutorials/configuration/index.md @@ -104,7 +104,7 @@ export default defineConfig({ ### `poweredByHeader` -By default, Hydrogen responds with the `x-powered-by: Shopify-Hydrogen` header. You can disable this by adding `poweredByHeader: false` to your config: +By default, Hydrogen responds with the `powered-by: Shopify, Hydrogen` header. You can disable this by adding `poweredByHeader: false` to your config: ```tsx // hydrogen.config.ts diff --git a/packages/hydrogen/src/entry-server.tsx b/packages/hydrogen/src/entry-server.tsx index 34ce51705a..0cfd75d88c 100644 --- a/packages/hydrogen/src/entry-server.tsx +++ b/packages/hydrogen/src/entry-server.tsx @@ -136,7 +136,7 @@ export const renderHydrogen = (App: any) => { if (hydrogenConfig.poweredByHeader ?? true) { // If undefined in the config, then always show the header - response.headers.set('powered-by', 'Shopify-Hydrogen'); + response.headers.set('powered-by', 'Shopify, Hydrogen'); } sessionApi ??= hydrogenConfig.session?.(log); diff --git a/packages/playground/server-components/tests/e2e-test-cases.ts b/packages/playground/server-components/tests/e2e-test-cases.ts index 2e8f4fca1d..5dd7e76a24 100644 --- a/packages/playground/server-components/tests/e2e-test-cases.ts +++ b/packages/playground/server-components/tests/e2e-test-cases.ts @@ -274,7 +274,7 @@ export default async function testCases({ it('returns powered-by header', async () => { const response = await fetch(getServerUrl() + '/'); - expect(response.headers.get('powered-by')).toBe('Shopify-Hydrogen'); + expect(response.headers.get('powered-by')).toBe('Shopify, Hydrogen'); }); it('properly escapes props in the SSR flight script chunks', async () => {