Support React experimental #1541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blittle
approved these changes
Jun 13, 2022
Contributor
blittle
left a comment
blittle
left a comment
There was a problem hiding this comment.
We should maybe provide feedback to React core that there should be a more official way to determine RSC mode vs SSR mode.
jplhomer
approved these changes
Jun 13, 2022
Contributor
jplhomer
left a comment
jplhomer
left a comment
There was a problem hiding this comment.
Slick. To your point @blittle, I'm guessing this is possible if we switched to use the Node conditions flag (where react-server package exports only execute in the RSC runtime), and we could more cleanly inject some flag or logic at that point. I think we'll end up switching to that in our next iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the changes in #1452 and #1473 , Hydrogen is not compatible with the experimental version of React anymore (only stable version) because the
getCacheForTypemethod is also implemented in the Fizz/SSR dispatcher.This PR updates the RSC plugin to inject an
isRscboolean variable in the Flight/RSC dispatcher that we can read later.Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning