Use self-signed certificates in --no-tunnel mode
#4422
Conversation
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1900 tests passing in 861 suites. Report generated by 🧪jest coverage report action from cc4b21a |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationspackages/cli-kit/dist/public/node/testing/test-with-temp-dir.d.tsimport { TestAPI } from 'vitest';
interface TempDirFixture {
tempDir: string;
}
/**
* Vitest fixture providing the test with a temporary directory to work in.
*/
export declare const testWithTempDir: TestAPI<TempDirFixture>;
export {};
Existing type declarationspackages/cli-kit/dist/public/node/github.d.ts@@ -47,4 +47,5 @@ export interface GithubRepositoryReference {
* @param reference - A GitHub repository URL (e.g. https://github.com/Shopify/cli/blob/main/package.json)
*/
export declare function parseGitHubRepositoryReference(reference: string): GithubRepositoryReference;
+export declare function downloadGitHubRelease(repo: string, version: string, assetName: string, targetPath: string): Promise<void>;
export {};
\ No newline at end of file
|
|
/snapit |
|
🫰✨ Thanks @shauns! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
|
/snapit |
|
🫰✨ Thanks @shauns! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
WHY are these changes introduced?
Changes
--no-tunnelto producehttps://localhost...URLs, which are more widely compatible with the rest of the Shopify platform, making that mode a compelling alternative to using a tunnel.SHOPIFY_CLI_MKCERT_BINARYis set, use the binary at that path<app directory>/.shopify/mkcertin the app's codebasemkcertif installed (viawhich)mkcertfrom github if needed, and place it in the app directory as abovedevis not typically used in CI/CD, but if desired, the use of the environment variable is probably best.The certificates generated are
localhost.pemandlocalhost-key.pemin<app directory>/.shopify.Almost always, adding the
mkcertbinary and the.pemfiles to.gitignoreis desirable. We should probably update our app templates accordingly.WHAT is this pull request doing?
devin--no-tunnelmodeHow to test your changes?
Run
devwith--no-tunnel. You can also use the--reset-mkcertoption to get to a pristine state.Measuring impact
How do we know this change was effective? Please choose one:
Checklist