♻️ Move files into #core, #utils to enable tsc typechecking (ampproject#36277)

* Add #utils path alias

* Move format/analytics/animation/event-hepler/log into #util/core

* update imports of log => #utils/log

* update imports of format => #core/document/format

* Update imports of event-helper

* Update imports of analytics

* Update imports of animation

* lint autofix

* Update forbidden-terms

* Move #core/document-{ready,visibility} to #core/document/{ready,visibility}

* Update imports of #core/document-{ready,visibility}

* Fix imports in #core/document/visibility

* Move test files to reflect new structure

* Lint fixes

* Lint fixes to babel plugins

* Fix babel plugin paths

* Fix babel plugin paths

* Fix dep-check config

* Fix type-check shame

* Typo

Author: rcebulko

Diff for: 3p/3d-gltf/index.js

@@ -6,9 +6,9 @@ import {listenParent, nonSensitiveDataPostMessage} from '#3p/messaging';
 import {dict} from '#core/types/object';
 import {parseJson} from '#core/types/object/json';
 
-import GltfViewer from './viewer';
+import {user} from '#utils/log';
 
-import {user} from '../../src/log';
+import GltfViewer from './viewer';
 
 const seq = (taskA, taskB) => (cb) => taskA(() => taskB(cb));
 const parallel = (taskA, taskB) => (cb) => {

Diff for: 3p/3p.js

@@ -9,7 +9,7 @@ import {rethrowAsync} from '#core/error';
 import {isArray} from '#core/types';
 import {hasOwn, map} from '#core/types/object';
 
-import {devAssert, userAssert} from '../src/log';
+import {devAssert, userAssert} from '#utils/log';
 
 /** @typedef {function(!Window, !Object)}  */
 let ThirdPartyFunctionDef;

Diff for: 3p/ampcontext-integration.js

@@ -1,10 +1,10 @@
 import {dict} from '#core/types/object';
 
+import {dev, user, userAssert} from '#utils/log';
+
 import {computeInMasterFrame} from './3p';
 import {AbstractAmpContext} from './ampcontext';
 
-import {dev, user, userAssert} from '../src/log';
-
 /**
  * Returns the "master frame" for all widgets of a given type.
  * This frame should be used to e.g. fetch scripts that can

Diff for: 3p/ampcontext-lib.js

@@ -1,9 +1,9 @@
 // src/polyfills.js must be the first import.
 import './polyfills';
 
-import {AmpContext} from './ampcontext';
+import {initLogConstructor, setReportError} from '#utils/log';
 
-import {initLogConstructor, setReportError} from '../src/log';
+import {AmpContext} from './ampcontext';
 
 initLogConstructor();
 

Diff for: 3p/ampcontext.js

@@ -5,9 +5,10 @@ import {isObject} from '#core/types';
 import {dict, map} from '#core/types/object';
 import {tryParseJson} from '#core/types/object/json';
 
+import {dev, devAssert} from '#utils/log';
+
 import {IframeMessagingClient} from './iframe-messaging-client';
 
-import {dev, devAssert} from '../src/log';
 import {parseUrlDeprecated} from '../src/url';
 
 export class AbstractAmpContext {

Diff for: 3p/bodymovinanimation.js

@@ -3,9 +3,9 @@ import {tryPlay} from '#core/dom/video';
 import {dict} from '#core/types/object';
 import {parseJson} from '#core/types/object/json';
 
-import {loadScript} from './3p';
+import {getData} from '#utils/event-helper';
 
-import {getData} from '../src/event-helper';
+import {loadScript} from './3p';
 
 const libSourceUrl = dict({
   'canvas':

Diff for: 3p/facebook.js

@@ -3,9 +3,9 @@ import {isEnumValue} from '#core/types/enum';
 import {dict} from '#core/types/object';
 import {dashToUnderline} from '#core/types/string';
 
-import {loadScript} from './3p';
+import {devAssert} from '#utils/log';
 
-import {devAssert} from '../src/log';
+import {loadScript} from './3p';
 
 /** @const @enum {string} */
 export const FacebookEmbedType = {

Diff for: 3p/frame-metadata.js

@@ -2,7 +2,8 @@ import {once} from '#core/types/function';
 import {dict} from '#core/types/object';
 import {parseJson} from '#core/types/object/json';
 
-import {dev} from '../src/log';
+import {dev} from '#utils/log';
+
 import {getMode} from '../src/mode';
 import {parseUrlDeprecated} from '../src/url';
 

Diff for: 3p/github.js

@@ -1,6 +1,6 @@
-import {writeScript} from './3p';
+import {userAssert} from '#utils/log';
 
-import {userAssert} from '../src/log';
+import {writeScript} from './3p';
 
 /**
  * Get the correct script for the gist.

Diff for: 3p/iframe-messaging-client.js

@@ -7,8 +7,9 @@ import {
 import {Observable} from '#core/data-structures/observable';
 import {dict, map} from '#core/types/object';
 
-import {getData} from '../src/event-helper';
-import {dev} from '../src/log';
+import {getData} from '#utils/event-helper';
+import {dev} from '#utils/log';
+
 import {getMode} from '../src/mode';
 
 export class IframeMessagingClient {

Diff for: 3p/iframe-transport-client-lib.js

@@ -1,9 +1,9 @@
 // src/polyfills.js must be the first import.
 import './polyfills';
 
-import {IframeTransportClient} from './iframe-transport-client';
+import {initLogConstructor, setReportError} from '#utils/log';
 
-import {initLogConstructor, setReportError} from '../src/log';
+import {IframeTransportClient} from './iframe-transport-client';
 
 initLogConstructor();
 // TODO(alanorozco): Refactor src/error.reportError so it does not contain big

Diff for: 3p/iframe-transport-client.js

@@ -1,9 +1,9 @@
 import {IframeTransportEventDef, MessageType} from '#core/3p-frame-messaging';
 import {tryParseJson} from '#core/types/object/json';
 
-import {IframeMessagingClient} from './iframe-messaging-client';
+import {dev, devAssert, user, userAssert} from '#utils/log';
 
-import {dev, devAssert, user, userAssert} from '../src/log';
+import {IframeMessagingClient} from './iframe-messaging-client';
 
 /** @private @const {string} */
 const TAG_ = 'iframe-transport-client';

Diff for: 3p/integration-lib.js

@@ -3,18 +3,19 @@ import {dict} from '#core/types/object';
 import {parseJson} from '#core/types/object/json';
 import {endsWith} from '#core/types/string';
 
+import {
+  initLogConstructor,
+  isUserErrorMessage,
+  setReportError,
+  userAssert,
+} from '#utils/log';
+
 import {run, setExperimentToggles} from './3p';
 import {IntegrationAmpContext} from './ampcontext-integration';
 import {installEmbedStateListener, manageWin} from './environment';
 import {getAmpConfig, getEmbedType, getLocation} from './frame-metadata';
 
 import {urls} from '../src/config';
-import {
-  initLogConstructor,
-  isUserErrorMessage,
-  setReportError,
-  userAssert,
-} from '../src/log';
 import {getSourceUrl, isProxyOrigin, parseUrlDeprecated} from '../src/url';
 
 /**

Diff for: 3p/integration.js

@@ -13,7 +13,7 @@ import './polyfills';
 import {draw3p, init} from './integration-lib';
 import {getMode} from '../src/mode';
 import {register} from './3p';
-import {user} from 'src/log';
+import {user} from '#utils/log';
 
 // 3P - please keep in alphabetic order
 import {beopinion} from './beopinion';

Diff for: 3p/mathml.js

@@ -1,8 +1,8 @@
 import {setStyle} from '#core/dom/style';
 
-import {writeScript} from './3p';
+import {userAssert} from '#utils/log';
 
-import {userAssert} from '../src/log';
+import {writeScript} from './3p';
 
 /**
  * Get the correct script for the mathml formula.

Diff for: 3p/messaging.js

@@ -1,6 +1,6 @@
 import {parseJson} from '#core/types/object/json';
 
-import {getData} from '../src/event-helper';
+import {getData} from '#utils/event-helper';
 
 /**
  * Send messages to parent frame. These should not contain user data.

Diff for: 3p/recaptcha.js

@@ -4,16 +4,17 @@ import './polyfills';
 import {dict, hasOwn} from '#core/types/object';
 import {parseJson} from '#core/types/object/json';
 
-import {loadScript} from './3p';
-import {IframeMessagingClient} from './iframe-messaging-client';
-
 import {
   dev,
   devAssert,
   initLogConstructor,
   setReportError,
   user,
-} from '../src/log';
+} from '#utils/log';
+
+import {loadScript} from './3p';
+import {IframeMessagingClient} from './iframe-messaging-client';
+
 import {isProxyOrigin, parseUrlDeprecated} from '../src/url';
 import ampToolboxCacheUrl from '../third_party/amp-toolbox-cache-url/dist/amp-toolbox-cache-url.esm';
 

Diff for: 3p/viqeoplayer.js

@@ -1,9 +1,9 @@
 import {tryPlay} from '#core/dom/video';
 import {tryDecodeUriComponent} from '#core/types/string/url';
 
-import {loadScript} from './3p';
+import {getData} from '#utils/event-helper';
 
-import {getData} from '../src/event-helper';
+import {loadScript} from './3p';
 
 /**
  * @param {Window} global

Diff for: ads/alp/handler.js

@@ -5,7 +5,7 @@ import {
   parseUrlDeprecated,
 } from '../../src/url';
 import {closest} from '#core/dom/query';
-import {dev} from '../../src/log';
+import {dev} from '#utils/log';
 import {dict} from '#core/types/object';
 import {openWindowDialog} from '../../src/open-window-dialog';
 import {parseQueryString} from '#core/types/string/url';

Diff for: ads/alp/install-alp.js

@@ -1,6 +1,6 @@
 // Utility file that generates URLs suitable for AMP's impression tracking.
 
-import {initLogConstructor, setReportError} from '../../src/log';
+import {initLogConstructor, setReportError} from '#utils/log';
 import {installAlpClickHandler, warmupStatic} from './handler';
 import {reportError} from '../../src/error-reporting';
 

Diff for: ads/google/a4a/test/test-utils.js

@@ -35,7 +35,7 @@ import {installDocService} from '#service/ampdoc-impl';
 import {installExtensionsService} from '#service/extensions-impl';
 import {installXhrService} from '#service/xhr-impl';
 import {toggleExperiment} from '#experiments';
-import {user} from '../../../../src/log';
+import {user} from '#utils/log';
 
 function setupForAdTesting(fixture) {
   installDocService(fixture.win, /* isSingleDoc */ true);

Diff for: ads/google/a4a/utils.js

@@ -3,7 +3,7 @@ import {DomFingerprint} from '#core/dom/fingerprint';
 import {GEO_IN_GROUP} from '../../../extensions/amp-geo/0.1/amp-geo-in-group';
 import {Services} from '#service';
 import {buildUrl} from './shared/url-builder';
-import {dev, devAssert, user} from '../../../src/log';
+import {dev, devAssert, user} from '#utils/log';
 import {dict} from '#core/types/object';
 import {getBinaryType, isExperimentOn, toggleExperiment} from '#experiments';
 import {getConsentPolicyState} from '../../../src/consent';

Diff for: ads/google/doubleclick.js

@@ -1,4 +1,4 @@
-import {dev} from '../../src/log';
+import {dev} from '#utils/log';
 
 const TAG = 'DOUBLECLICK - DEPRECATED';
 /**

Diff for: ads/google/ima/ima-video.js

@@ -1,7 +1,7 @@
 import {CONSENT_POLICY_STATE} from '#core/constants/consent-state';
 import {ImaPlayerData} from './ima-player-data';
 import {camelCaseToTitleCase, setStyle, toggle} from '#core/dom/style';
-import {getData} from '../../../src/event-helper';
+import {getData} from '#utils/event-helper';
 import {htmlFor, htmlRefs, svgFor} from '#core/dom/static-template';
 import {isArray, isObject} from '#core/types';
 import {loadScript} from '#3p/3p';

Diff for: ads/google/utils.js

@@ -4,7 +4,7 @@ import {
   getAutoConfig,
   getPubControlConfig,
 } from './a4a/shared/content-recommendation';
-import {user} from '../../src/log';
+import {user} from '#utils/log';
 
 /**
  * Approved height for AdSense full-width responsive ads.

Diff for: ads/inabox/inabox-host.js

@@ -4,8 +4,8 @@
  */
 
 import {InaboxMessagingHost} from './inabox-messaging-host';
-import {dev, initLogConstructor, setReportError, user} from '../../src/log';
-import {getData} from '../../src/event-helper';
+import {dev, initLogConstructor, setReportError, user} from '#utils/log';
+import {getData} from '#utils/event-helper';
 import {reportError} from '../../src/error-reporting';
 
 /** @const {string} */

Diff for: ads/inabox/inabox-messaging-host.js

@@ -4,9 +4,9 @@ import {
   serializeMessage,
 } from '#core/3p-frame-messaging';
 import {canInspectWindow} from '../../src/iframe-helper';
-import {dev, devAssert} from '../../src/log';
+import {dev, devAssert} from '#utils/log';
 import {dict} from '#core/types/object';
-import {getData} from '../../src/event-helper';
+import {getData} from '#utils/event-helper';
 import {getFrameOverlayManager} from './frame-overlay-manager';
 import {getPositionObserver} from './position-observer';
 

Diff for: ads/vendors/_ping_.js

@@ -1,4 +1,4 @@
-import {dev, devAssert, userAssert} from '../../src/log';
+import {dev, devAssert, userAssert} from '#utils/log';
 import {validateData} from '#3p/3p';
 
 /**

Diff for: ads/vendors/criteo.js

@@ -1,4 +1,4 @@
-import {dev} from '../../src/log';
+import {dev} from '#utils/log';
 import {loadScript} from '#3p/3p';
 
 /* global Criteo: false */

Diff for: ads/vendors/csa.js

@@ -1,4 +1,4 @@
-import {devAssert} from '../../src/log';
+import {devAssert} from '#utils/log';
 import {getStyle, setStyle, setStyles} from '#core/dom/style';
 import {loadScript, validateData} from '#3p/3p';
 import {tryParseJson} from '#core/types/object/json';

Diff for: ads/vendors/netletix.js

@@ -1,5 +1,5 @@
 import {addParamsToUrl, assertHttpsUrl} from '../../src/url';
-import {dev} from '../../src/log';
+import {dev} from '#utils/log';
 import {dict} from '#core/types/object';
 import {loadScript, validateData, writeScript} from '#3p/3p';
 

Diff for: ads/vendors/promoteiq.js

@@ -1,6 +1,6 @@
 import {loadScript, validateData} from '#3p/3p';
 import {parseJson} from '#core/types/object/json';
-import {user} from '../../src/log';
+import {user} from '#utils/log';
 
 const TAG = 'PROMOTEIQ';
 const mandatoryDataFields = ['src', 'params', 'sfcallback'];

Diff for: ads/vendors/yieldbot.js

@@ -1,7 +1,7 @@
 import {getMultiSizeDimensions} from '#ads/google/utils';
 import {loadScript, validateData} from '#3p/3p';
 import {rethrowAsync} from '#core/error';
-import {user} from '../../src/log';
+import {user} from '#utils/log';
 
 /**
  * @param {!Window} global

Diff for: build-system/babel-plugins/babel-plugin-transform-dev-methods/index.js

@@ -57,7 +57,7 @@ module.exports = function () {
               resolve(dirname(state.file.opts.filename), source.value)
             );
 
-            if (filepath.endsWith('src/log')) {
+            if (filepath.endsWith('utils/log')) {
               const propertyMapped = calleeToPropertiesMap.get(
                 specifier.imported.name
               );

Diff for: build-system/babel-plugins/babel-plugin-transform-dev-methods/test/fixtures/transform-assertions/imported-both-no-usage/input.js

@@ -1 +1 @@
-import {dev, user} from '../../../../../../../src/log';
+import {dev, user} from '#utils/log';

Diff for: build-system/babel-plugins/babel-plugin-transform-dev-methods/test/fixtures/transform-assertions/imported-both-no-usage/output.mjs

@@ -1 +1 @@
-import { dev, user } from '../../../../../../../src/log';
+import { dev, user } from '#utils/log';

Diff for: build-system/babel-plugins/babel-plugin-transform-dev-methods/test/fixtures/transform-assertions/imported-both-usage/input.js

@@ -1,4 +1,4 @@
-import {dev, user} from '../../../../../../../src/log';
+import {dev, user} from '#utils/log';
 
 dev().info(
   TAG,
@@ -47,4 +47,4 @@ class Foo {
     dev().error(TAG, 'Should not be removed');
     user().error('Should not be removed');
   }
-}
+}

Diff for: build-system/babel-plugins/babel-plugin-transform-dev-methods/test/fixtures/transform-assertions/imported-both-usage/output.mjs

@@ -1,4 +1,4 @@
-import { dev, user } from '../../../../../../../src/log';
+import { dev, user } from '#utils/log';
 dev().info;
 user().fine;
 

Diff for: build-system/babel-plugins/babel-plugin-transform-dev-methods/test/fixtures/transform-assertions/imported-dev-no-usage/input.js

@@ -1 +1 @@
-import {dev} from '../../../../../../../src/log';
+import {dev} from '#utils/log';

Diff for: build-system/babel-plugins/babel-plugin-transform-dev-methods/test/fixtures/transform-assertions/imported-dev-no-usage/output.mjs

@@ -1 +1 @@
-import { dev } from '../../../../../../../src/log';
+import { dev } from '#utils/log';