This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Allow RPC calls using block hash or number of latest block #313
Merged
FabijanC
merged 16 commits into
0xSpaceShard:master
from
cptartur:feat/rpc-assert-latest-block
Oct 21, 2022
Merged
Allow RPC calls using block hash or number of latest block #313
FabijanC
merged 16 commits into
0xSpaceShard:master
from
cptartur:feat/rpc-assert-latest-block
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabijanC
suggested changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
- Accepted block IDs can be documented in
page/docs/guide/json-rpc-api.md
. - Currently only
"latest"
is tested. Shouldn't providing"pending"
also be tested?
|
Addressed the comments. I've also unchecked "tests are passing" because |
FabijanC
suggested changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloned your fork, postman test is passing.
FabijanC
changed the title
Allow making RPC calls using block hash or number of a latest block
Allow RPC calls using block hash or number of latest block
Oct 21, 2022
FabijanC
approved these changes
Oct 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
"latest"
as block hash/number. With this PR it is also possible to use ablock_hash
orblock_number
if they belong to the latest block."pending"
block, though it is still treated as a"latest"
block (up to discussion if this should be included).indirect=True
, to parametrized fixtures.Development related changes
None
Checklist:
./scripts/format.sh
./scripts/lint.sh