New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a minor issue replay.py #103

Open

ainilaha wants to merge 1 commit into ShangtongZhang:master from ainilaha:fix-minor-issue-reply

ainilaha commented Nov 13, 2020

A keyword async used as a parameter in the __init__(self, replay_cls, replay_kwargs, async=True): function of ReplayWrapper, and it raises a syntax error when I run the code on a local machine with python 3.5 and 3.8 (I have not tried with docker).

>>> import keyword
>>> keyword.kwlist
['False', 'None', 'True', 'and', 'as', 'assert', 'async',...

Therefore, async has been replaced with async_flag.

It seems unnecessary to pass the async=True in the examples.py because the default value is True.


          fix a minor issue replay.py

b8bd169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet