Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Auto-select my kingdom if there is only one left #33

Open
d-albrecht opened this issue Oct 18, 2022 · 3 comments
Open

Suggestion: Auto-select my kingdom if there is only one left #33

d-albrecht opened this issue Oct 18, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@d-albrecht
Copy link

No matter how you play the game, it is highly likely that at some point you will have exactly one kingdom. Whether this is by combining all kingdoms or getting some destroyed by others. Would it be possible to automatically select this single remaining kingdom as soon as it is my turn, such that I can immediately click on "buy unit" or "buy castle"?

It is possible that you "get back" to having several kingdoms afterwards, and hence, the automation has to check each round/turn if it should trigger. But I see no obvious reason to have the player do an additional yet unnecessary mouse click / display touch. And if you want to select the kingdom manually, nothing will stop you from doing so, it will just have no real effect to select the only remaining and already selected kingdom.

@Sesu8642 Sesu8642 added the enhancement New feature or request label Oct 18, 2022
@Sesu8642
Copy link
Owner

Yes, that makes sense. I previously thought of remembering and re-selecting the kingdom that was active in the previous turn but that turned out to be rather complicated. In the case where there is only one left, it should be pretty straight forward.

@d-albrecht
Copy link
Author

I just realized, if you have only one kingdom left and the kingdom gets auto-selected, this might mess with the warning dialog about "forgotten kingdoms" in the way that you could hit the "end turn" button without doing anything and the game might count that as a turn (which you might not have intended) or warn you (when you knowingly didn't want to change anything). So, you might have to come up with what suits you more. Both solutions have their drawbacks. But either way I would prefer to not have to select the only remaining kingdom. Personally, I would probably prefer that you get a warning if you didn't do anything this turn, but as far as I have already looked into the code, this might be the more difficult approach code-wise.

@Sesu8642
Copy link
Owner

I also prefer showing the warning in that situation. The Kingdom#setWasActiveInCurrentTurn would need to be called every time the player does any action in the kingdom and just like now when it is activated. In that one case where it is auto-activated, that would need to be skipped or set back to false again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants