Skip to content

Conversation

@NicolasAG
Copy link
Collaborator

@NicolasAG NicolasAG commented Jun 16, 2025

  • move the Miniwob agent example to domains/
  • update miniwob config to not use tool calling. Instead it uses json step predictions
  • scale up the number of env servers similarly to the number of actor vllm servers

@NicolasAG NicolasAG self-assigned this Jun 16, 2025
@NicolasAG NicolasAG marked this pull request as ready for review July 11, 2025 14:40
@NicolasAG NicolasAG requested review from AlexPiche and ollmer July 11, 2025 14:40
@NicolasAG NicolasAG requested a review from ollmer October 14, 2025 13:56
@NicolasAG NicolasAG removed the request for review from AlexPiche November 25, 2025 19:42
Copy link
Collaborator

@ollmer ollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ollmer
Copy link
Collaborator

ollmer commented Nov 27, 2025

@rafapi I would like to merge this before my new actor PR, looks like it only affects miniwob rollouts, the only change affecting common actor logic is enforcing group size check:

                assert len(rollout_results) == attempts, (
                    f"Expected {attempts} rollouts, got {len(rollout_results)}"
                )

in actor.py. Are you ok to merge that?

@NicolasAG NicolasAG requested a review from rafapi November 27, 2025 20:34
@rafapi
Copy link
Collaborator

rafapi commented Nov 28, 2025

could we also merge main here?

Copy link
Collaborator

@rafapi rafapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ollmer ollmer merged commit 86635bd into main Nov 28, 2025
@ollmer ollmer deleted the debug_miniwob branch November 28, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants