-
Notifications
You must be signed in to change notification settings - Fork 30
Debug the Miniwob example #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ollmer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@rafapi I would like to merge this before my new actor PR, looks like it only affects miniwob rollouts, the only change affecting common actor logic is enforcing group size check: in actor.py. Are you ok to merge that? |
|
could we also merge main here? |
rafapi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
domains/