feat: align AI Hub UX and Strix GitHub Models - #350
Merged
Merged
Conversation
Contributor
|
PR governance metadata gate is not ready for
|
Contributor
|
Warning Review limit reached
More reviews will be available in 53 minutes and 22 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR updates Strix security scans to default to GPT-5 via GitHub Models (with fallbacks) instead of GPT-4.1, introduces model/API-base compatibility gating, and adds AI Hub execution checkpoint sections displaying context, decision, and action data in the frontend. ChangesStrix GPT-5 GitHub Models Default & Routing
AI Hub Execution Checkpoint Sections
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
scripts/ci/test_strix_quick_gate.sh (1)
6873-6880: ⚡ Quick winAdd an executed
openai/gpt-5-nanofallback case.The workflow assertions now require both GitHub Models fallbacks, but this suite only exercises
openai/gpt-5-miniend-to-end. A brokengpt-5-nanonormalization or routing path would still pass here.As per coding guidelines, "GitHub Models fallbacks use
openai/gpt-5-miniandopenai/gpt-5-nano."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/ci/test_strix_quick_gate.sh` around lines 6873 - 6880, The test suite only exercises the fallback path for "openai/gpt-5-mini" but the workflow assertions require both GitHub Models fallbacks; add a new run_gate_case invocation mirroring the existing "github-models-fallback-success" call but using "openai/gpt-5-nano" as the fallback model (replace the third argument), keep the same test name or use a distinct name like "github-models-fallback-success-nano", keep other args (primary "vertex_ai/missing-primary", expected regex, timeout, model list and URLs) consistent with the existing "openai/gpt-5-mini" case so the normalization/routing for gpt-5-nano is executed end-to-end.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/AIHubLayout.tsx`:
- Line 292: In AIHubLayout update the nav's aria-label to a Korean string to
match the page language: locate the nav element that currently sets
aria-label="AI hub execution checkpoints" and replace that English label with a
Korean equivalent (e.g., "AI 허브 실행 체크포인트") so the accessible name for the
navigation matches the visible UI language.
- Around line 417-419: The early return in AIHubLayout removes the whole
right-hand "최근 실행 근거" panel when workflows is empty; instead remove the
top-level return and conditionally render the EmptyState only in the workflows
column (e.g., render <EmptyState ... /> where workflows would be listed) while
always rendering the recent evidence panel (use events or events.length to
decide whether to show its content). Update the component so AIHubLayout no
longer returns early on workflows.length === 0, but shows the EmptyState inside
the left pane and preserves the right-hand recent-evidence UI (reference
workflows, events, EmptyState and the recent evidence panel in AIHubLayout).
---
Nitpick comments:
In `@scripts/ci/test_strix_quick_gate.sh`:
- Around line 6873-6880: The test suite only exercises the fallback path for
"openai/gpt-5-mini" but the workflow assertions require both GitHub Models
fallbacks; add a new run_gate_case invocation mirroring the existing
"github-models-fallback-success" call but using "openai/gpt-5-nano" as the
fallback model (replace the third argument), keep the same test name or use a
distinct name like "github-models-fallback-success-nano", keep other args
(primary "vertex_ai/missing-primary", expected regex, timeout, model list and
URLs) consistent with the existing "openai/gpt-5-mini" case so the
normalization/routing for gpt-5-nano is executed end-to-end.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 85cc7d14-5eb9-4331-a3d8-30c1b91d521b
📒 Files selected for processing (14)
.github/workflows/strix.ymlAGENTS.mdbackend/tests/test_ai_hub_api.pybackend/tests/test_release_governance.pydocs/plans/2026-05-27-strix-openai-direct-only.mddocs/plans/2026-05-29-strix-full-scan-operational-model.mddocs/plans/2026-05-29-strix-vertex-model-warning-filter.mdfrontend/src/app/ai-hub/page.test.tsxfrontend/src/components/AIHubLayout.tsxfrontend/tests/e2e/ai-hub-source-surface.spec.tsfrontend/tests/e2e/dashboard-branding.spec.tsfrontend/tests/e2e/helpers.tsscripts/ci/strix_quick_gate.shscripts/ci/test_strix_quick_gate.sh
Contributor
Author
|
Resolved the CodeRabbit review comments in 3d08ad6. @coderabbitai review |
Contributor
|
🧠 Learnings used✅ Action performedReview finished.
|
seonghobae
enabled auto-merge
June 5, 2026 06:02
Contributor
Author
|
@coderabbitai approve |
Contributor
✅ Action performedComments resolved and changes approved. |
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Summary by CodeRabbit
New Features
Documentation
Tests