From 5c14bd7248ff595ae95624307c52023a9a64f44c Mon Sep 17 00:00:00 2001 From: "claude[bot]" <41898282+claude[bot]@users.noreply.github.com> Date: Tue, 27 Jan 2026 18:13:43 +0000 Subject: [PATCH 1/5] chore: add pre-merge check for newline in perf-changelog.yaml Add a validation step in run-sweep.yml that ensures perf-changelog.yaml ends with a newline character. This prevents negative diff issues in subsequent PRs when the file is appended to. Closes #578 Co-authored-by: Cameron Quilici --- .github/workflows/run-sweep.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/run-sweep.yml b/.github/workflows/run-sweep.yml index 671a1681d1..33cadafebc 100644 --- a/.github/workflows/run-sweep.yml +++ b/.github/workflows/run-sweep.yml @@ -35,6 +35,15 @@ jobs: with: fetch-depth: 0 + - name: Check perf-changelog.yaml ends with newline + run: | + if [ -n "$(tail -c 1 perf-changelog.yaml)" ]; then + echo "::error::perf-changelog.yaml must end with a newline character" + echo "Please add a newline at the end of the file to avoid diff issues in subsequent PRs." + exit 1 + fi + echo "✓ perf-changelog.yaml ends with newline" + - id: setup run: | pip install pydantic From 0a75f6d5bbd064a91a4afd3fc9f1b657bf875c6e Mon Sep 17 00:00:00 2001 From: Cam Quilici Date: Tue, 27 Jan 2026 15:52:00 -0600 Subject: [PATCH 2/5] test --- perf-changelog.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/perf-changelog.yaml b/perf-changelog.yaml index 07772d370a..87e8043a19 100644 --- a/perf-changelog.yaml +++ b/perf-changelog.yaml @@ -273,3 +273,9 @@ - "Update MI355X DeepSeek R1 FP8 SGLang image from v0.5.5.post3 to v0.5.8" - "Key fix: Disables mla persistent kernel when not using fp8 kv_cache (https://github.com/sgl-project/sglang/pull/17327)" pr-link: https://github.com/InferenceMAX/InferenceMAX/pull/572 + +- config-keys: + - dsr1-fp8-mi355x-sglang + description: + - "test" + pr-link: test \ No newline at end of file From 0d0ce47020d083d15a1c6d25c80c45ab5e432c31 Mon Sep 17 00:00:00 2001 From: Cam Quilici Date: Tue, 27 Jan 2026 15:57:01 -0600 Subject: [PATCH 3/5] change logic of newline check --- .github/workflows/run-sweep.yml | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/.github/workflows/run-sweep.yml b/.github/workflows/run-sweep.yml index 33cadafebc..eef4620404 100644 --- a/.github/workflows/run-sweep.yml +++ b/.github/workflows/run-sweep.yml @@ -22,18 +22,12 @@ on: - "perf-changelog.yaml" jobs: - setup: + check-newline: runs-on: ubuntu-latest - if: >- - (github.event_name == 'pull_request' && !github.event.pull_request.draft && contains(github.event.pull_request.labels.*.name, 'sweep-enabled')) || - (github.event_name != 'pull_request' && !contains(github.event.head_commit.message, '[skip-sweep]')) - outputs: - search-space-config: ${{ steps.setup.outputs.search-space-config }} + if: github.event_name == 'pull_request' && !github.event.pull_request.draft steps: - name: Checkout code uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - with: - fetch-depth: 0 - name: Check perf-changelog.yaml ends with newline run: | @@ -42,7 +36,19 @@ jobs: echo "Please add a newline at the end of the file to avoid diff issues in subsequent PRs." exit 1 fi - echo "✓ perf-changelog.yaml ends with newline" + + setup: + runs-on: ubuntu-latest + if: >- + (github.event_name == 'pull_request' && !github.event.pull_request.draft && contains(github.event.pull_request.labels.*.name, 'sweep-enabled')) || + (github.event_name != 'pull_request' && !contains(github.event.head_commit.message, '[skip-sweep]')) + outputs: + search-space-config: ${{ steps.setup.outputs.search-space-config }} + steps: + - name: Checkout code + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + with: + fetch-depth: 0 - id: setup run: | From 793bc2d6d37fa92c1f751cf9d3b9988592886d35 Mon Sep 17 00:00:00 2001 From: Cam Quilici Date: Tue, 27 Jan 2026 15:58:08 -0600 Subject: [PATCH 4/5] trigger test check From 2f62234cc7233c7c5993a18b5ab463ce37360685 Mon Sep 17 00:00:00 2001 From: Cam Quilici Date: Tue, 27 Jan 2026 16:00:20 -0600 Subject: [PATCH 5/5] remove test perf changelog --- perf-changelog.yaml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/perf-changelog.yaml b/perf-changelog.yaml index 8d04bab656..9071dae2d6 100644 --- a/perf-changelog.yaml +++ b/perf-changelog.yaml @@ -235,9 +235,3 @@ - "Update MI355X DeepSeek R1 FP8 SGLang image from v0.5.5.post3 to v0.5.8" - "Key fix: Disables mla persistent kernel when not using fp8 kv_cache (https://github.com/sgl-project/sglang/pull/17327)" pr-link: https://github.com/InferenceMAX/InferenceMAX/pull/572 - -- config-keys: - - dsr1-fp8-mi355x-sglang - description: - - "test" - pr-link: test \ No newline at end of file