Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LESS npm package missing 'themes/*/assets' #5821

Closed
Panoplos opened this issue Oct 1, 2017 · 10 comments
Closed

LESS npm package missing 'themes/*/assets' #5821

Panoplos opened this issue Oct 1, 2017 · 10 comments

Comments

@Panoplos
Copy link

Panoplos commented Oct 1, 2017

Linking here due to inactivity on the less git.

Semantic-Org/Semantic-UI-LESS#28

@awgv awgv added this to the Needs Milestone milestone Oct 7, 2017
@awgv
Copy link
Member

awgv commented Oct 7, 2017

Hi @Panoplos, sorry for the delay, but I can’t seem to reproduce, and all assets are there. Did you manage to get it fixed during the week?

@Panoplos
Copy link
Author

Panoplos commented Oct 9, 2017

No, just tested again, and still no-go. Did a yarn remove semantic-ui-less and yarn add semantic-ui-less.

~/Documents/Development/Node.js/project
⟩ find node_modules/semantic-ui-less/ -name assets

~/Documents/Development/Node.js/project
⟩ 

Did you clear your npm cache before testing?

@awgv
Copy link
Member

awgv commented Oct 9, 2017

@Panoplos No.

@Panoplos
Copy link
Author

OK, can you try in a clean environment or give me some pointer as to how to get this fixed?

@awgv
Copy link
Member

awgv commented Oct 10, 2017

@Panoplos I would if I could, but I don’t know why it happens—I tried several things yesterday, but nothing was reproducing the issue. I’m sorry that it happened, the only thing I can do is to summon the maintainer, perhaps he’ll have time to take a look at it this week; @jlukic.

@Panoplos
Copy link
Author

Yeah, it is a strange issue, indeed, but it is a showstopper for us. If I can provide any further info that would help, just ask.

@p3nGu1nZz
Copy link

@Panoplos I just tested this can i can not reproduce either. However I made you a quick fix.

here is a forked tag of the 2.2.13 release:
src => https://github.com/1-14x0r/Semantic-UI-LESS/tree/just-themes
tag => https://github.com/1-14x0r/Semantic-UI-LESS/releases/tag/2.2.13a

basically remove the module from your package.json and extract the themes dir to overwrite your existin' one in the module..

Alternative You could also keep the module as it is, and copy over the static files you in your src. just make sure your build task copies over the assets. main.

i know its some hackery but that is the best idea i have. Sounds alot like some type of issue with your local configuration or network. o_0

GLHF;

@Panoplos
Copy link
Author

Panoplos commented Nov 8, 2017

I finally figured out what the problem was! In the default .yarnclean config file, it is specifying assets as a directory to "clean", which was deleting all assets. Really stupid problem and not sure why yarn clean has implemented defaults in this manner... I will report the issue in their repo.

@Panoplos
Copy link
Author

Panoplos commented Nov 8, 2017

See: yarnpkg/yarn#4879

@awgv
Copy link
Member

awgv commented Nov 8, 2017

Thank you, @Panoplos. Their response seems to be reasonable, and I think the thread can now be closed as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants