Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] #4196 Disable refreshing for non active/animated modals #5319

Merged
merged 1 commit into from
Jul 2, 2017
Merged

[Modal] #4196 Disable refreshing for non active/animated modals #5319

merged 1 commit into from
Jul 2, 2017

Conversation

p2kmgcl
Copy link
Contributor

@p2kmgcl p2kmgcl commented Apr 26, 2017

This commit solves #4196
When two or more modals coexist on the same page, the refresh method
of each modal is executed, even if one of them is being shown.
By checking if the module is active or being animated, you prevent
conflicts between shown and hidden modals, like the one described in
the issue.

This commit solves #4196
When two or more modals coexist on the same page, the refresh method
of each modal is executed, even if one of them is being shown.
By checking if the module is active or being animated, you prevent
conflicts between shown and hidden modals, like the one described in
the issue.
@jlukic jlukic added this to the 2.2.13 milestone Apr 27, 2017
@jlukic
Copy link
Member

jlukic commented Jul 2, 2017

Looks good as gold, sorry for the delay.

@jlukic jlukic modified the milestones: 2.2.11, 2.2.13 Jul 2, 2017
@jlukic jlukic merged commit dd8a8b1 into Semantic-Org:next Jul 2, 2017
@p2kmgcl p2kmgcl deleted the issue/4196 branch July 3, 2017 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants