Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #4183 #4510

Merged
merged 1 commit into from
Mar 18, 2018
Merged

Fix for #4183 #4510

merged 1 commit into from
Mar 18, 2018

Conversation

martinduparc
Copy link
Contributor

text argument missing for select action

`text` argument missing for select action
@martinduparc martinduparc changed the title Update dropdown.js Fix for #4183 Aug 31, 2016
@jlukic jlukic added this to the 2.2.5 milestone Sep 20, 2016
@jlukic jlukic modified the milestones: 2.2.5, 2.2.7 Oct 28, 2016
@jlukic jlukic modified the milestones: 2.2.8, 2.2.9 Feb 21, 2017
@jlukic jlukic modified the milestones: 2.2.10, 2.2.11 Mar 28, 2017
@jlukic jlukic modified the milestones: 2.2.11, 2.2.12 Jul 11, 2017
@jlukic jlukic modified the milestones: 2.2.14, 2.2.15 Jan 29, 2018
@jlukic
Copy link
Member

jlukic commented Feb 20, 2018

Can someone elaborate on this, I'm not sure what is/isnt relevant to current version

@jlukic jlukic modified the milestones: 2.2.15, 2.2.16 Feb 20, 2018
@jlukic
Copy link
Member

jlukic commented Mar 18, 2018

I've read through the original thread #4183 and it is still an issue. I tested this fix and it looks good, thanks for your PR.

@jlukic jlukic changed the base branch from master to next March 18, 2018 21:40
@jlukic jlukic merged commit 7ebb821 into Semantic-Org:next Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants