-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm install with autoInstall:true in semantic.json does not copy or build dist files #4436
Comments
Reopened PR - added 'build' option in semantic.json to control whether to gulp build immediately after autoinstall. |
Please... merge and push it straight away.... this is definitely broke!~ |
+1 ... please merge this! |
+1 This is what I expected to happen with the autoInstall option present |
It's sad to see this issue is still open 👎 |
It seems to work for me using the following {
"base": "semantic\\",
"paths": {
"source": {
"config": "src/theme.config",
"definitions": "src/definitions/",
"site": "src/site/",
"themes": "src/themes/"
},
"output": {
"packaged": "dist/",
"uncompressed": "dist/components/",
"compressed": "dist/components/",
"themes": "dist/themes/"
},
"clean": "dist/"
},
"permission": false,
"autoInstall": true,
"rtl": false
}
# dependencies
/node_modules
/bower_components
semantic/gulpfile.js
semantic/src
semantic/tasks
semantic/dist/*
!semantic/dist/*.min.js
!semantic/dist/*.min.css Make sure to keep When installing after |
Please fix this... it's broken on our DeployBot setup due to being unable to install via |
The PR #4430 has been merged, if anyone still has this problem please make sure you're using a version of Semantic UI higher than 2.2.9. |
Still having this issue deploying on Netlify. I'm trying to deploy a Storybook instance and the Gulp postinstall keeps breaking the deploy, despite changing the Here's my build command:
Receive this error on deploy:
With this {
"base": "",
"paths": {
"source": {
"config": "src/theme.config",
"definitions": "src/definitions/",
"site": "src/site/",
"themes": "src/themes/"
},
"output": {
"packaged": "dist/",
"uncompressed": "dist/components/",
"compressed": "dist/components/",
"themes": "dist/themes/"
},
"clean": "dist/"
},
"permission": false,
"autoInstall": true,
"rtl": false,
"version": "2.4.2"
} And here's my
|
If you have a semantic.json file with autoInstall:true - npm install will just install the semantic-ui files in node_modules, and not complete copying the files out to semantic/ and run gulp build as a manual install would.
Created fix: #4430
I closed the PR for now to do more testing with other semantic.json options.
The text was updated successfully, but these errors were encountered: