Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistent use of media query breakpoints #3180

Merged
merged 1 commit into from
Oct 14, 2015

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Oct 14, 2015

In modal.less and step.less, a max-width of @computerBreakpoint is used, causing an inconsistency when the browser is exactly 992px width (ie most queries switch on the 991-992 change, but these switch on the 992-993 change).

  • @largest* should only be used by max-width queries
  • @*Breakpoint should only be used by min-width queries

This PR makes the use of these variables more consistent.

 - @largest* should only be used by max-width queries
 - @*Breakpoint should only be used by min-width queries
@jlukic jlukic added this to the 2.1.5 milestone Oct 14, 2015
@jlukic
Copy link
Member

jlukic commented Oct 14, 2015

I can confirm these should all be @largest(X)Size as you've specified. Merging in.

jlukic added a commit that referenced this pull request Oct 14, 2015
Fixed inconsistent use of media query breakpoints
@jlukic jlukic merged commit bd2d74b into Semantic-Org:next Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants