docs(Input): refactor, add trailing . in description, fix imports #679
Conversation
…x wrong props on Button and add required prop selection to Dropdown
Current coverage is 100% (diff: 100%)
|
| const InputExampleActionDropdown = () => ( | ||
| <Input | ||
| action={<Dropdown basic floating options={options} defaultValue='page' />} | ||
| action={<Dropdown selection basic floating options={options} defaultValue='page' />} |
There was a problem hiding this comment.
This should not be aselection Dropdown, reference: http://semantic-ui.com/elements/input#action
There was a problem hiding this comment.
I removed selection, but it complains:
Warning: Failed prop type: `options` prop in `Dropdown` requires props: `selection`.
in Dropdown (created by InputExampleActionDropdown)
in InputExampleActionDropdown
|
|
||
| const InputExampleActionLabeledButton = () => ( | ||
| <Input | ||
| action={{ color: 'teal', label: 'right', icon: 'copy', content: 'Copy' }} |
There was a problem hiding this comment.
The prop label is for defining the label, the prop labelPosition is for placing it on the left/right. This should be labelPosition: 'right'.
|
|
||
| const InputExampleLeftActionLabeledButton = () => ( | ||
| <Input | ||
| action={{ color: 'teal', label: true, icon: 'cart', content: 'Checkout' }} |
There was a problem hiding this comment.
The previous labeled prop became labelPosition. This should be labelPosition: 'left' which will place the icon as a label on the left.
levithomason
left a comment
levithomason
left a comment
There was a problem hiding this comment.
One more update please, then I think we can merge it.
| const InputExampleRightLabeled = () => ( | ||
| <Input | ||
| label={<Dropdown defaultValue='.com' options={options} />} | ||
| label={<Dropdown selection defaultValue='.com' options={options} />} |
There was a problem hiding this comment.
The selection prop should also not be added here:
with selection
without selection
|
@levithomason removed prop selection from Dropdown. Thank you for pointing this. |
levithomason
changed the title
|
Thanks much :) |
3 participants
Uh oh!
There was an error while loading. Please reload this page.