Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card: add centered prop to Card.Group #2453

Closed
FIL1994 opened this issue Jan 20, 2018 · 4 comments
Closed

Card: add centered prop to Card.Group #2453

FIL1994 opened this issue Jan 20, 2018 · 4 comments
Labels
enhancement

Comments

@FIL1994
Copy link

FIL1994 commented Jan 20, 2018

Add centered prop to Card.Group
@brianespinosa
Copy link
Member

Confirmed that .ui.cards in SUI does support the additional class of .centered in the CSS. We should add support for this in Card.Group with a boolean centered prop.

@FIL1994 for now, you can achieve this by adding a className of "centered" to your Card.Group.

@sudheerDev
Copy link
Contributor

@brianespinosa can i give this a shot?.

@brianespinosa
Copy link
Member

@sudheerDev absolutely! PRs are always welcome.

@sudheerDev sudheerDev mentioned this issue Jan 25, 2018
Merged
@sudheerDev
Copy link
Contributor

@brianespinosa I did create a PR but not sure why coverage came down in visibility.js. Should I add an example for centred?.

@layershifter layershifter changed the title Add centered prop to Card.Group [Suggestion] Card: add centered prop to Card.Group Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brianespinosa @sudheerDev @layershifter @FIL1994