Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlled Popup doesn't handle hideOnScroll #2346

Closed
amaury1093 opened this issue Nov 30, 2017 · 2 comments
Closed

Controlled Popup doesn't handle hideOnScroll #2346

amaury1093 opened this issue Nov 30, 2017 · 2 comments

Comments

@amaury1093
Copy link

Steps

  1. Create a controlled Popup with hideOnScroll prop set to true.
        <Popup
          trigger={...}
          content="..."
          on="click"
          hideOnScroll
          open={this.state.isOpen}
          onOpen={this.handleOpen}
          onClose={this.handleClose}
        />
  1. Click on the trigger to show the popup

  2. Scroll the page

Expected Result

The popup should hide, and the onClose method should be called.

Actual Result

The popup hides only during scroll, and reappears at scroll end. onClose is never called.

Version

0.75.1

Testcase

https://codesandbox.io/s/8x9pryv602

@smallbrownbike
Copy link

smallbrownbike commented Nov 30, 2017

@amaurymartiny No issues with this on 0.77.0. Have you thought about updating?

@amaury1093
Copy link
Author

Correct, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants