Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight in the Documentation: Dropdown requires className='link item' #2304

Closed
ZoeVonFeng opened this issue Nov 9, 2017 · 3 comments
Closed
Labels

Comments

@ZoeVonFeng
Copy link

When trying to create a simple dropdown menu, as I thought className is user defined so I removed it, then it took me a good one hour to debug why my dropdown button is out of place.
<Dropdown text='Shopping' pointing className='link item'>

I think such kind "hard requirement" should be highlighted in Props.

@layershifter
Copy link
Member

I dont understand about what you are speaking. Please fill the issue template and add more details.

@ZoeVonFeng
Copy link
Author

Sorry, let me try it again. This was just a request to make Documentation contains more details regarding to this issue.
WIth the original code;

  <Menu>
    <Menu.Item>
      Home
    </Menu.Item>
    <Dropdown text='Shopping' pointing className='link item'>
    </Dropdown>
  </Menu>

image

If we remove className, since in REACT className could be optional. So the dropdown code would be like:
<Dropdown text='Shopping' pointing >
image

I just think if Sematic UI is using link item as reserved className. it should be mentioned in the Documentation.

@layershifter
Copy link
Member

layershifter commented Nov 10, 2017

This is a temporialy workaround, this should be following:

Dropdown as={Menu.Item}

But, it's not possible to do now, see #2306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants