Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form.Input, div class="error required field", margin-bottom: 1em. #2286

Closed
ghost opened this issue Nov 3, 2017 · 4 comments
Closed

Form.Input, div class="error required field", margin-bottom: 1em. #2286

ghost opened this issue Nov 3, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 3, 2017

✔ BUGS (I think)

Steps

<Form.Input ... />
myLabel

Expected Result

<div class="error required field"><div class="ui left icon input">...</div></div>
with margin-bottom: 0px

Actual Result

<div class="error required field"><div class="ui left icon input">...</div></div>
with margin-bottom: 1em

from

.ui.form .field {
    clear: both;
    margin: 0 0 1em;
}

Version

"semantic-ui-react": "^0.75.1",

@ghost
Copy link
Author

ghost commented Nov 3, 2017

Or maybe the problem is this:

.ui.pointing.label, .ui[class*="pointing above"].label {
    margin-top: 1em;
}

Why this?

I think this is good instead:

.ui.pointing.label, .ui[class*="pointing above"].label {
    margin-bottom: 1em;
}

@brianespinosa
Copy link
Member

Hello, @johnunclesam without completing the required codesandbox example with your report, we can't tell for sure what the problem is that you are experiencing. However, it does look like you are referencing CSS rules, which are out of scope for SUIR. All CSS issues should be reported to the core SUI repository here: https://github.com/Semantic-Org/Semantic-UI

@ghost
Copy link
Author

ghost commented Nov 7, 2017

After this Semantic-Org/Semantic-UI#5918 (comment) I ask to reopen this issue because of this below SUIR code that generates wrong html.

<Form className="attached segment" size="large">
  <Form.Input
    type="email"
    name="email"
    icon="at"
    iconPosition="left"
    label="Email"
    error={true}
    required
    value={email}
    onChange={this.onChange}
  />
  <Label color="red" pointing="above">
    myLabel
  </Label>
</Form>

@brianespinosa
Copy link
Member

@johnunclesam This issue was closed because it was related to applying inline styles incorrectly and it did not include a codesandbox example which is required for all bug reports. What you are pointing out here is different.

Please open a new issue and complete the entire report including a codesandbox example.

@Semantic-Org Semantic-Org locked and limited conversation to collaborators Nov 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant