-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portal/Popups incompatible with preact-compat #1969
Comments
PRs increasing interop with other libraries are very much welcomed. Closing for housekeeping as there are no errors with React and this library is intended to be used with React only. |
@layershifter Thanks for the response, and I understand that this is not an intended use case. I've started work on a fix, but won't raise a PR until I have proper test cases established. |
I had this issue and fixed it by wrapping my trigger component in a div. |
I wrapped my triggers component with a div but still getting that @nialloc9 Where you getting this exact error ( |
Issue persists for me |
TL;DR
When using Popups with
preact-compat
, the event object passed tohandleOpen
from the associated Portal does not contain acurrentTarget
property, due to the way the event object is being cloned. This throws an error, preventing the Popup from being displayed when it is triggered by a mouse event.Steps
preact-cli
.semantic-ui-react
(andsemantic-ui-css
) as described in its documentation.preact-compat
in place of React using Webpack, overriding the webpack config using the method described inpreact-cli
's documentation.Expected Result
Actual Result
Version
0.71.4
Testcase
Unable to provide test case, unless CodePen allows module aliasing
The text was updated successfully, but these errors were encountered: